Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Replace deprecated seccomp.security.alpha.kubernetes.io/pod annotation #11966 #12058

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Revert Replace deprecated seccomp.security.alpha.kubernetes.io/pod annotation #11966 #12058

merged 2 commits into from
Aug 11, 2022

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Aug 11, 2022 •
edited

Description

Workspaces do not start in the preview environment unless we revert #11966

Related Issue(s)

Related to #11966

How to test

  1. Try starting a workspace from https://kylos101-d8796e1ca0a.preview.gitpod-dev.com/workspaces, it will work.
  2. Try starting a workspace from https://kylos101-f3157a06d2e.preview.gitpod-dev.com/workspaces, it will not work, as these changes haven't been reverted from that branch.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-preview

@kylos101
Revert "Update test files"
e3cec77 
This reverts commit 6886784.
@roboquat roboquat added size/XL and removed size/S labels Aug 11, 2022
@kylos101 kylos101 changed the title do not merge Revert Replace deprecated seccomp.security.alpha.kubernetes.io/pod annotation #11966 Aug 11, 2022
@kylos101 kylos101 marked this pull request as ready for review August 11, 2022 03:58
@kylos101 kylos101 requested a review from a team August 11, 2022 03:58
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Aug 11, 2022
sagor999
sagor999 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting why it did break preview environments, but approving to unblock

@roboquat roboquat merged commit 1693255 into main Aug 11, 2022
@roboquat roboquat deleted the kylos101/does-main-work branch August 11, 2022 04:23
@sagor999
Copy link
Contributor

@aledbf

@kylos101
Copy link
Contributor Author

For posterity the error we get in preview is below (last event in the list):

5m23s       Normal    Scheduled                 pod/ws-fa2b8d53-e6fc-4872-b328-9b069f8db427             Successfully assigned default/ws-fa2b8d53-e6fc-4872-b328-9b069f8db427 to kylos101-d8796e1ca0a
5m23s       Normal    Pulling                   pod/ws-fa2b8d53-e6fc-4872-b328-9b069f8db427             Pulling image "reg.kylos101-d8796e1ca0a.preview.gitpod-dev.com:30879/remote/fa2b8d53-e6fc-4872-b328-9b069f8db427"
5m1s        Normal    Pulled                    pod/ws-fa2b8d53-e6fc-4872-b328-9b069f8db427             Successfully pulled image "reg.kylos101-d8796e1ca0a.preview.gitpod-dev.com:30879/remote/fa2b8d53-e6fc-4872-b328-9b069f8db427" in 21.847608126s
21s         Normal    Pulled                    pod/ws-fa2b8d53-e6fc-4872-b328-9b069f8db427             Container image "reg.kylos101-d8796e1ca0a.preview.gitpod-dev.com:30879/remote/fa2b8d53-e6fc-4872-b328-9b069f8db427" already present on machine
2m48s       Warning   Failed                    pod/ws-fa2b8d53-e6fc-4872-b328-9b069f8db427             Error: failed to create containerd container: cannot load seccomp profile "/var/lib/kubelet/seccomp/localhost/workspace_default_kylos101-does-main-work.0.json": open /var/lib/kubelet/seccomp/localhost/workspace_default_kylos101-does-main-work.0.json: no such file or directory

@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagor999 sagor999 sagor999 approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XL team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kylos101 @sagor999 @roboquat