Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Mark instances whose image build failed as "stopped" #12139

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Aug 15, 2022

Description

This is a leftover/oversight from long ago. It does not make sense to mark an instances as failed when not also setting it to stopped.

Related Issue(s)

Fixes #12138

How to test

Release Notes

Mark workspace's whose image builds failed as `stopped`

Documentation

Werft options:

  • /werft with-preview

@geropl geropl requested a review from a team August 15, 2022 14:28
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Aug 15, 2022
@roboquat roboquat merged commit ddd81de into main Aug 16, 2022
@roboquat roboquat deleted the gpl/12138-stop branch August 16, 2022 12:20
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop workspace instances whose image build failed
3 participants