Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ws-daemon] Check runc download is a binary #13270

Merged
merged 1 commit into from
Sep 26, 2022
Merged

[ws-daemon] Check runc download is a binary #13270

merged 1 commit into from
Sep 26, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 25, 2022 •
edited
Loading

Description

Ensure download is a binary

Also update cloud SDK to v402.

Related Issue(s)

root@g70c9281d74ad68b6cd195b:/home/aledbf# k exec -it -c ws-daemon ws-daemon-v7skj -- bash
root@ws-daemon-v7skj:/# which runc
/usr/bin/runc
root@ws-daemon-v7skj:/# runc
/usr/bin/runc: line 1: syntax error near unexpected token `<'
/usr/bin/runc: line 1: `<?xml version="1.0" encoding="utf-8"?><Error><Code>ServerBusy</Code><Message>Egress is over the account limit.'
root@ws-daemon-v7skj:/#

How to test

Release Notes

NONE

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@aledbf aledbf requested a review from a team September 25, 2022 15:56
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Sep 25, 2022
kylos101
kylos101 reviewed Sep 25, 2022
View reviewed changes
components/ws-daemon/debug.Dockerfile

FROM ubuntu:22.04

## Installing coreutils is super important here as otherwise the loopback device creation fails!
ARG CLOUD_SDK_VERSION=390.0.0
ARG CLOUD_SDK_VERSION=402.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why upgrade? Is there something concrete in the changelog to handle EOF here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already twelve versions behind. There are no breaking changes, and the SDK switched to python 3 as default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger that, thank you for checking!

@roboquat roboquat merged commit af45552 into main Sep 26, 2022
@roboquat roboquat deleted the aledbf/check branch September 26, 2022 00:12
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylos101 kylos101 kylos101 left review comments

@utam0k utam0k utam0k approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @kylos101 @utam0k @roboquat