Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JetBrains] Add Rider & CLion to beta #14524

Merged
merged 1 commit into from
Nov 18, 2022
Merged

[JetBrains] Add Rider & CLion to beta #14524

merged 1 commit into from
Nov 18, 2022

Conversation

andreafalzetti
Copy link
Contributor

@andreafalzetti andreafalzetti commented Nov 8, 2022 •
edited
Loading

Description

Adds JetBrains Rider and CLion support in Beta.

Depends on: gitpod-io/leeway#112

Rider CLion
Screenshot 2022-11-17 at 15 06 00 Screenshot 2022-11-17 at 15 31 52

Related Issue(s)

Fixes #14497

How to test

  1. Open https://afalz-14497-jb-ides.preview.gitpod-dev.com
  2. Start a workspace for Rider with a .NET project: https://afalz-14497-jb-ides.preview.gitpod-dev.com/#https://github.com/dotnet/roslyn, try using the IDE and use smart language features, auto-completion, etc
  3. Go to preferences and change preferred editor to CLion
  4. Start a workspace for CLion with a C++ project: https://afalz-14497-jb-ides.preview.gitpod-dev.com/#https://github.com/gitpod-io/template-cpp
  5. Start a workspace for https://afalz-14497-jb-ides.preview.gitpod-dev.com/#https://github.com/andreafalzetti/parcel-demo/tree/jb-proxy-test and make sure that the proxy settings are maintained (this is to verify that we don't have a regression on the config path resolver which we recently added to copy inside the JB options)

Release Notes

JetBrains: Add Rider and CLion IDEs in Beta

Documentation

https://github.com/gitpod-io/website/pull/3013

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-afalz-14497-jb-ides.1 because the annotations in the pull request description changed
(with .werft/ from main)

@andreafalzetti andreafalzetti force-pushed the afalz/14497-jb-ides branch 7 times, most recently from b45b132 to b4dd94a Compare November 9, 2022 10:08
@felladrin
Copy link
Contributor

felladrin commented Nov 10, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Code reviewed! ✅

I see we'll need to keep the lines that remove .framework files for now.

@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Nov 10, 2022 •
edited
Loading

Code reviewed! ✅

Thanks for reviewing 🙏 This PR is missing 2 things before I can set it ready for review:

  1. As you said, the .framework files, we should try resolving otherwise it will become tech-debt and for some users it won't work (those are Xamarin.IOS dependencies)
  2. The dashboard needs updating to either display 5 IDEs per row, or havign a select input

I'll work on these today

@andreafalzetti andreafalzetti mentioned this pull request Nov 10, 2022
Closed
gtsiolis
gtsiolis reviewed Nov 10, 2022
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads-up: @andreafalzetti You may are already aware of this, but I was in the neighborhood and gave this a try. Left one issue comment below. Cc @felladrin

components/dashboard/tailwind.config.js Outdated Show resolved Hide resolved
@loujaybee loujaybee mentioned this pull request Nov 10, 2022
Closed
8 tasks
@aledbf aledbf mentioned this pull request Nov 11, 2022
Merged
4 tasks
@aledbf
Copy link
Member

aledbf commented Nov 12, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-afalz-14497-jb-ides.15
(with .werft/ from main)

@aledbf aledbf mentioned this pull request Nov 13, 2022
Merged
4 tasks
@aledbf
Copy link
Member

aledbf commented Nov 14, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-afalz-14497-jb-ides.19
(with .werft/ from main)

@andreafalzetti andreafalzetti force-pushed the afalz/14497-jb-ides branch 2 times, most recently from 0c7745e to e9abd6e Compare November 17, 2022 13:24
@andreafalzetti andreafalzetti marked this pull request as ready for review November 17, 2022 13:47
@andreafalzetti andreafalzetti marked this pull request as draft November 17, 2022 14:40
@andreafalzetti andreafalzetti force-pushed the afalz/14497-jb-ides branch 2 times, most recently from da32576 to 3d653f9 Compare November 17, 2022 16:48
@andreafalzetti
Copy link
Contributor Author

andreafalzetti commented Nov 17, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run recreate-preview

👍 started the job as gitpod-build-afalz-14497-jb-ides.33
(with .werft/ from main)

@roboquat roboquat added size/XL and removed size/L labels Nov 17, 2022
@andreafalzetti andreafalzetti marked this pull request as ready for review November 17, 2022 21:52
@felladrin
Copy link
Contributor

felladrin commented Nov 18, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Code re-reviewed! ✅

I'll run some tests on the Preview Environment now.

felladrin
felladrin approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎉

image

image

image

geropl
geropl approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebApp changes LGTM ✅

@roboquat roboquat merged commit 6324566 into main Nov 18, 2022
@roboquat roboquat deleted the afalz/14497-jb-ides branch November 18, 2022 12:43
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis left review comments

@felladrin felladrin felladrin approved these changes

@easyCZ easyCZ easyCZ left review comments

@akosyakov akosyakov akosyakov left review comments

@mustard-mh mustard-mh mustard-mh left review comments

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production editor: jetbrains release-note size/XL team: IDE team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Rider and CLion IDEs
9 participants
@andreafalzetti @felladrin @aledbf @gtsiolis @easyCZ @akosyakov @mustard-mh @geropl @roboquat