Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update leeway to v0.4.1 #14637

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Update leeway to v0.4.1 #14637

merged 3 commits into from
Nov 14, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 12, 2022

Description

Fix leeway error building provenance sha256 hash

xref: #14524

How to test

  • Open https://gitpod.io/#https://github.com/gitpod-io/gitpod/pull/14524
  • In a terminal update leeway running wget https://github.com/gitpod-io/leeway/releases/download/v0.4.1/leeway_0.4.1_Linux_x86_64.tar.gz && tar zxpvf leeway_0.4.1_Linux_x86_64.tar.gz
  • Run the failing task ./leeway build components/ide/jetbrains/image:download-rider-latest

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@roboquat roboquat added size/M and removed size/XS labels Nov 13, 2022
@aledbf
Copy link
Member Author

aledbf commented Nov 13, 2022

gitpod /workspace/gitpod (afalz/14497-jb-ides) $ ./leeway build components/ide/jetbrains/image:download-rider-latest
☁️  checking remote cache for past build artifacts
🔧  build  components/ide/jetbrains/image:download-rider-latest  (version a85c6ba1bb27af0ba81153753bb82cc171d12462)

[components/ide/jetbrains/image:download-rider-latest] build started (version a85c6ba1bb27af0ba81153753bb82cc171d12462)
[components/ide/jetbrains/image:download-rider-latest] package build succeded (174.55s)
☁️  uploading build artifacts to remote cache

build succeded

@aledbf aledbf marked this pull request as ready for review November 13, 2022 00:14
@aledbf aledbf requested review from a team November 13, 2022 00:14
@github-actions github-actions bot added team: SID team: devx team: IDE team: workspace Issue belongs to the Workspace team labels Nov 13, 2022
Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be great if we also upgrade other files that contain leeway to 0.4.1

image

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested leeway run dev/preview:build and it works like a charm.

@felladrin
Copy link
Contributor

It will be great if we also upgrade other files that contain leeway to 0.4.1

image

I think we'll need to create a bot for keeping leeway up to date on all those cases.

@github-actions
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@aledbf
Copy link
Member Author

aledbf commented Nov 14, 2022

@felladrin done

@felladrin
Copy link
Contributor

Thanks! Now waiting for the last review, from @gitpod-io/engineering-delivery-operations-experience.

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@roboquat roboquat merged commit b110f7b into main Nov 14, 2022
@roboquat roboquat deleted the aledbf/leeway401 branch November 14, 2022 11:20
@roboquat roboquat added the deployed: IDE IDE change is running in production label Nov 14, 2022
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note-none size/M team: devx team: IDE team: SID team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants