Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always allow running new prebuilds, regardless of any previous prebuild state #15147

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Always allow running new prebuilds, regardless of any previous prebuild state #15147

merged 2 commits into from
Dec 6, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Dec 5, 2022 •
edited
Loading

Description

Make the 'Run Prebuild' button actually do what it says 100% of the time.

Related Issue(s)

Fixes #15144

How to test

  1. Create a Team
  2. Create a Project (this runs a first prebuild)
  3. When the prebuild has finished successfully, try to re-trigger the prebuild -- this should always work (i.e. it should always start a new prebuild, and not redirect you to an older successful prebuild)

Release Notes

Always allow running new prebuilds, regardless of any previous prebuild state

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-jx-run-prebuild.2 because the annotations in the pull request description changed
(with .werft/ from main)

@roboquat roboquat added the size/M label Dec 5, 2022
@roboquat roboquat added size/L and removed size/M labels Dec 5, 2022
@jankeromnes jankeromnes marked this pull request as ready for review December 5, 2022 15:43
@jankeromnes jankeromnes requested a review from a team December 5, 2022 15:43
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 5, 2022
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Dec 5, 2022 •
edited
Loading

Hint: Reviewing while ignoring identation changes is easier ➡️ https://github.com/gitpod-io/gitpod/pull/15147/files?w=1

New in this PR:

  • (Re)Run Prebuild button always works (even when there is already a "successful" prebuild for the same commit)
  • We now always show the (Re)Run Prebuild button/action in the UI (regardless of any prebuild states)
Rerun Failed Prebuild Rerun Successful Prebuild Rerun For Any Branch Can Always Run Prebuild
Screenshot 2022-12-05 at 15 47 38 Screenshot 2022-12-05 at 15 45 59 Screenshot 2022-12-05 at 15 55 12 Screenshot 2022-12-05 at 16 10 13
Branch AAAH, failed Branch main, succeeded Project Overview ("Branches"), all context menus Prebuilds list, top button always visible

@jankeromnes jankeromnes changed the title [server] When a user triggers a new prebuild, always force the creation of a new prebuild Always allow running new prebuilds, regardless of any previous prebuild state Dec 5, 2022
svenefftinge
svenefftinge approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 2ab0cc4 into main Dec 6, 2022
@roboquat roboquat deleted the jx/run-prebuild branch December 6, 2022 07:16
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev left review comments

@svenefftinge svenefftinge svenefftinge approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the 'Run Prebuild' button more consistent
4 participants
@jankeromnes @svenefftinge @AlexTugarev @roboquat