Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code] queue write/resize terminal requests #4560

Closed
wants to merge 1 commit into from
Closed

[code] queue write/resize terminal requests #4560

wants to merge 1 commit into from

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 21, 2021 •
edited
Loading

What it does

Changes in Gitpod Code: gitpod-io/openvscode-server@924ed5c

It should be merged after #4565

How to test

  • Start a workspace.
  • Type something and check that characters appear in proper order without substantial delay on good connection.
  • Resize and check with stty -a that sizes are changed.
  • Emulate slow connection on system level and test again.

@akosyakov akosyakov marked this pull request as ready for review June 21, 2021 05:48
@akosyakov akosyakov force-pushed the akosyakov/terminal-window-typing-4504 branch from 96383a9 to 5e2cd1e Compare June 21, 2021 07:20
@akosyakov akosyakov marked this pull request as draft June 21, 2021 08:33
@akosyakov
Copy link
Member Author

akosyakov commented Jun 21, 2021 •
edited
Loading

I will move it to the supervisor instead. 

See #4504 (comment)

@akosyakov akosyakov force-pushed the akosyakov/terminal-window-typing-4504 branch from 5e2cd1e to ff84433 Compare June 22, 2021 03:59
@akosyakov akosyakov marked this pull request as ready for review June 22, 2021 03:59
@akosyakov
[code] fix #4504: queue write/resize terminal requests
8f7b756 
Terminal API expects that clients take care to send next request after response to previous.
@akosyakov akosyakov force-pushed the akosyakov/terminal-window-typing-4504 branch from ff84433 to 8f7b756 Compare June 22, 2021 06:39
@JanKoehnlein
Copy link
Contributor

JanKoehnlein commented Jun 22, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-akosyakov-terminal-window-typing-4504.5

@akosyakov
Copy link
Member Author

merged as part of #4569

@akosyakov akosyakov closed this Jun 23, 2021
@akosyakov akosyakov deleted the akosyakov/terminal-window-typing-4504 branch June 23, 2021 02:11
@akosyakov akosyakov mentioned this pull request Jun 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKoehnlein JanKoehnlein JanKoehnlein approved these changes

@corneliusludmann corneliusludmann Awaiting requested review from corneliusludmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terminal Window Typing Out of Order
2 participants
@akosyakov @JanKoehnlein