Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code/supervisor] allow retry auto exposing port #4565

Merged
merged 1 commit into from
Jun 23, 2021
Merged

[code/supervisor] allow retry auto exposing port #4565

merged 1 commit into from
Jun 23, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jun 22, 2021 •
edited
Loading

What it does

Change in Gitpod Code: gitpod-io/openvscode-server@13852f7

This PR also contains a commit which allows only one control port request in 2mins. I will drop it before merging. It is required for testing.

How to test

  • Start a workspace and create 2 terminals.
  • In one terminal run curl lama.sh | LAMA_PORT=9000 sh
  • In another terminal run curl lama.sh | LAMA_PORT=9001 sh
  • You should see that only one port will be detected and another will fail.
  • In 2 mins after that, you should be able to click retry to expose on failed port and it will succeed as well.

@akosyakov akosyakov force-pushed the akosyakov/ports-notify-a-user-about-3160 branch 2 times, most recently from 1f60f9d to 053e62c Compare June 22, 2021 02:55
@akosyakov akosyakov marked this pull request as ready for review June 22, 2021 03:32
@akosyakov akosyakov mentioned this pull request Jun 22, 2021
Closed
@akosyakov akosyakov force-pushed the akosyakov/ports-notify-a-user-about-3160 branch from 053e62c to 3d8e6cd Compare June 22, 2021 06:38
@JanKoehnlein
Copy link
Contributor

JanKoehnlein commented Jun 22, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-akosyakov-ports-notify-a-user-about-3160.10

JanKoehnlein
JanKoehnlein approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosyakov akosyakov mentioned this pull request Jun 23, 2021
Closed
@akosyakov
Copy link
Member Author

merged as part of #4569

@akosyakov akosyakov closed this Jun 23, 2021
@akosyakov akosyakov deleted the akosyakov/ports-notify-a-user-about-3160 branch June 23, 2021 02:11
@akosyakov akosyakov mentioned this pull request Jun 23, 2021
Closed
@akosyakov akosyakov restored the akosyakov/ports-notify-a-user-about-3160 branch June 23, 2021 06:14
@akosyakov akosyakov reopened this Jun 23, 2021
@akosyakov akosyakov force-pushed the akosyakov/ports-notify-a-user-about-3160 branch from 3d8e6cd to c143771 Compare June 23, 2021 06:21
@akosyakov akosyakov merged commit 57b7b7c into main Jun 23, 2021
@akosyakov akosyakov deleted the akosyakov/ports-notify-a-user-about-3160 branch June 23, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKoehnlein JanKoehnlein JanKoehnlein approved these changes

@corneliusludmann corneliusludmann Awaiting requested review from corneliusludmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ports] notify a user about failed auto port exposure and allow to restart it
2 participants
@akosyakov @JanKoehnlein