Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] confirm sharing #4743

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

akosyakov
Copy link
Member

This PR should be merged only after #4738!

What it does

Screenshot 2021-07-08 at 14 29 14

Gitpod Code Change: gitpod-io/openvscode-server@fde107c

How to test

Start a workspace and try to share.

@akosyakov akosyakov requested review from a team, rl-gitpod, fntlnz, JanKoehnlein and svenefftinge and removed request for a team July 8, 2021 09:35
@fntlnz
Copy link
Contributor

fntlnz commented Jul 9, 2021

Thank you @akosyakov !

@akosyakov akosyakov force-pushed the akosyakov/confirmation-popup-for-4726 branch from 88c8b33 to 8c14660 Compare July 13, 2021 03:27
@akosyakov akosyakov merged commit 4c9ef40 into main Jul 13, 2021
@akosyakov akosyakov deleted the akosyakov/confirmation-popup-for-4726 branch July 13, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirmation popup for workspace sharing
2 participants