[code] serve each webview from own origin

[akosyakov]

What it does

• fix [code] serve each webview from own origin #4529 by moving workpsace ID from foreign content URL origin to URL path. It allows to give each extension host and webview an unique origin at the same time enabling ws-proxy to route properly

Change in Gitpod Code: gitpod-io/openvscode-server@6cf68ce

How to test

• Start a workspace.
• Open the extensions view, try to preview GitLens extenison, content should be displayed.
• Then install GitLens extension, you should see Welcome page from this extension.
• Install VIM extension. It should be properly activated. Maybe you need to reload, but you should not see anything like failed to activate notifications.
• After that open devtools and inspect what kind of origins you have. It should be something like that:

Bonus: start a workspace for github.com/gitpod-io/vscode, wait for the build and then check everything in dev version

[codecov]

Codecov Report

Merging #4738 (74e60f0) into main (c060c81) will increase coverage by 36.78%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           main    #4738       +/-   ##
=========================================
+ Coverage      0   36.78%   +36.78%     
=========================================
  Files         0       13       +13     
  Lines         0     3670     +3670     
=========================================
+ Hits          0     1350     +1350     
- Misses        0     2204     +2204     
- Partials      0      116      +116     

Flag	Coverage Δ
components-ws-manager-app	36.78% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/ws-manager/pkg/manager/config.go	32.50% <ø> (ø)
components/ws-manager/pkg/manager/create.go	79.05% <100.00%> (ø)
components/ws-manager/pkg/manager/monitor.go	0.00% <0.00%> (ø)
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go	74.46% <0.00%> (ø)
...omponents/ws-manager/pkg/manager/pod_controller.go	0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/metrics.go	11.26% <0.00%> (ø)
components/ws-manager/pkg/manager/imagespec.go	0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/probe.go	0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/status.go	70.84% <0.00%> (ø)
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c060c81...74e60f0. Read the comment docs.

[csweichel]

For the review I'd greatly benefit from a joint walkthrough. Would you have some time tomorrow?

[geropl]

Starting to review now

[geropl]

/werft run

👍 started the job as gitpod-build-akosyakov-code-serve-each-webview-4529.16

[geropl]

@akosyakov Awesome change, really cool to see this "hack" resolved with a proper solution! 🚀 Plus the loom video really nails it: so much easier to grok the context and scope. I left a few comments, exclusively requests for more comments so my future me still knows what ws-proxy does 🙃

[akosyakov]

@geropl I refactored a bit and added comments with examples. Does it look good like that?

I'm going to add wsHost attribute to supervisor info endpoint also, but tomorrow. To replace parsing here: gitpod-io/openvscode-server@cd2128e#diff-b68e95d8ebaec9fc38aad38c3df9f68d2951bc577b3de330bf552bcafa7f1d34R277-R278

[geropl]

Awesome! Tested and works as advertised.

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [akosyakov,geropl]
• components/ide/OWNERS [akosyakov]
• components/proxy/OWNERS [geropl]
• components/supervisor/OWNERS [akosyakov]
• components/supervisor-api/OWNERS [akosyakov]
• components/ws-manager/OWNERS [akosyakov]
• components/ws-proxy/OWNERS [akosyakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[akosyakov]

@csweichel I added workspace_cluster_host to the supervisor info endpoint to avoid parsing it from URL location. Could you have a look please? I thought to name it workspace_host but i think it will be confusing, i would think it is coral-duck-93mwvmd2.ws-us11.gitpod.io not ws-us11.gitpod.io

[csweichel]

/lgtm

[roboquat]

New changes are detected. LGTM label has been removed.