[ide] added VS Code "Insiders" IDE variant #5024
Conversation
|
It's a bit stupid to test, as we have no new commits to gitpod/vscode:gp-code since the last stable build, so both options yield the same vscode version. I tested by setting the branch of the not yet merged PR https://github.com/gitpod-io/vscode/pull/22/files in the IDE dockerfile. We may want to revert that before merging. To test:
So it basically works. Any proposal to improve the display of the IDE buttons on the Settings page is welcome. At them moment "VS Code Insiders" is trimmed to "VS Code I...". Maybe we should call it "VS Code ß" (beta) or so. |
|
/werft run 👍 started the job as gitpod-build-jankoehnlein-code-preview-version-4965.2 |
|
/hold because of test commit |
|
Rendering is off: Does it make sense to add some warning when one selects Insider, explaining what it is? |
There was a problem hiding this comment.
Hi everyone! Left two minor comments below. Cc @JanKoehnlein @akosyakov
A boring (simple) solution here could be to use the same card components, remove the Insiders suffix and use a label at the bottom of the VS Code Insiders option like LATEST, INSIDERS, or UNSTABLE.
| Example (Latest) | Example (Insiders) |
|---|---|
 |
 |
In case this is helpful, the label component has been used in the What's New modal[1] and the upcoming Project Branches page[2]. 💡
🍊 🍊 🍊 🍊
In future iterations we could consider redesigning this component to be more flexible. Here's an early draft design how this could look like:
| Early Draft |
|---|
 |
🍋 🍋 🍋 🍋
Does it make sense to add some warning when one selects Insider, explaining what it is?
I think the label inside the card option could suffice. Additionally, we could update the section subtitle to be more accurate:
From:
Choose which IDE you want to use
To something like:
Choose an editor between VS Code, VS Code Insiders, and Theia.
| <img className="w-16 filter-grayscale" src={vscode}/> | ||
| </div> | ||
| </SelectableCard> | ||
| <SelectableCard className="w-36 h-40" title="VS Code Insiders" selected={defaultIde === 'code-insiders'} onClick={() => actuallySetDefaultIde('code-insiders')}> | ||
| <div className="flex-grow flex justify-center items-center"> | ||
| <img className="w-16 filter-grayscale" src={vscode}/> |
There was a problem hiding this comment.
suggestion: What do you think of using the actual VS Code Insider logo here which is slightly different? This could help regular VS Code users identify faster the difference between these two options.
There was a problem hiding this comment.
I am not such a big friend of the name "Insiders", because it's the latest port of our changes to the latest release of VS Code rather than the official VS Code Insiders (which is ahead of the current VS Code release). Do you think that matters or is that nitpicking?
There was a problem hiding this comment.
Oh, wait. Maybe I've missed the context here. I thought this was about having the option to switch to the official VS Code Insiders as the editor option. If this is about our changes on top of VS Code I'd vote for definitely removing the term Insiders altogether as it could be misleading.
Using a more user friendly term like Latest or Unstable sound more appropriate here, right?
There was a problem hiding this comment.
How about choosing between "VS Code stable" between "VS Code latest"?
Who would choose an unstable IDE?
There was a problem hiding this comment.
Using the Latest label sounds better here. I think we don't have to use any label for the Stable option within the product.
| <img className="w-16 filter-grayscale" src={vscode}/> | ||
| </div> | ||
| </SelectableCard> | ||
| <SelectableCard className="w-36 h-40" title="VS Code Insiders" selected={defaultIde === 'code-insiders'} onClick={() => actuallySetDefaultIde('code-insiders')}> |
There was a problem hiding this comment.
thought: To make this option friendlier to most users which could be unfamiliar with VS Code Insiders we could use a label here to mark this option as the latest or unstable option. 💭
|
We should probably also think how we indicate it in within IDE. |
|
/werft run 👍 started the job as gitpod-build-jankoehnlein-code-preview-version-4965.3 |
|
/werft run 👍 started the job as gitpod-build-jankoehnlein-code-preview-version-4965.4 |
JanKoehnlein
force-pushed
the
jankoehnlein/code-preview-version-4965
branch
from
1ca3971
to
002a1e9
Compare
JanKoehnlein
force-pushed
the
jankoehnlein/code-preview-version-4965
branch
from
002a1e9
to
503b7f2
Compare
|
@akosyakov I tried to use the latest commit on the gp-code branch as the "latest VS Code" commit, but then the image build fails: https://werft.gitpod-dev.com/job/gitpod-build-jankoehnlein-code-preview-version-4965.6 |
JanKoehnlein
force-pushed
the
jankoehnlein/code-preview-version-4965
branch
from
503b7f2
to
49b2b6a
Compare
|
/werft run 👍 started the job as gitpod-build-jankoehnlein-code-preview-version-4965.8 |
|
tooltip is off: |
|
/unhold |
|
LGTM label has been added. Git tree hash: 9405196baa2314f5f4d80ea52c222b2930e384af
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akosyakov, JanKoehnlein Associated issue: #4965 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #4965