Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] preview version for testing #4965

Closed
akosyakov opened this issue Jul 27, 2021 · 7 comments · Fixed by #5024 or #5147
Closed

[code] preview version for testing #4965

akosyakov opened this issue Jul 27, 2021 · 7 comments · Fixed by #5024 or #5147

Comments

@akosyakov
Copy link
Member

akosyakov commented Jul 27, 2021

We need to use VS Code before giving it to end users. It would be good to allow deploying a new version without switching all users to it.

@csweichel
Copy link
Contributor

We should revive the feature preview flag and use it for this decision. It's still in the database, and we could re-set it for Gitpod folks only.

@csweichel
Copy link
Contributor

To do this we'd pin the stable version and have the components/ide/code component build the "next generation".
We'd need an automatic mechanism to "promote" past builds to the stable build though. I reckon we could build something using prow.

@csweichel csweichel added the priority: high (dev loop impact) Gitpod development loop impacting issues label Jul 27, 2021
@csweichel
Copy link
Contributor

/schedule

@roboquat roboquat moved this from Inbox to Scheduled (limit: 25 WIP) in [DEPRECATED] Product Engineering Groundwork Jul 27, 2021
@csweichel
Copy link
Contributor

During an offline discussion with @geropl we outlined the following solution:

  • in the server IDE config we introduce code-preview which is set the current Code image build (the very same that previously set the code alias)
  • we make the "VSCode Preview" a selectable IDE on the dashboard, much like Theia
    image
  • the VS Code version that sets the default code alias is pinned to a gitpod-io/gitpod commit in a file in the repository.

Benefits:

  • this solution relies predominantly on concepts we already have
  • GItpod's versioning/config remains self-contained in the repository
  • we don't need any exceptions for any of the environments (e.g. no special prod deployment)
    • corollary: also works for self-hosted
  • we don't need to add in the "Feature Flag" mechanism to the new dashboard just yet

Maybe downside:

  • the additional VS Code (Preview) may be confusing for users

/cc @svenefftinge @gtsiolis WDYT about the "VS Code Preview" idea?

@akosyakov
Copy link
Member Author

We can call it insiders and it can be used for early adapters. It is the same with desktop VS Code and should not be confusing.

@JanKoehnlein
Copy link
Contributor

/assign

@JanKoehnlein
Copy link
Contributor

JanKoehnlein commented Aug 11, 2021

The PR has been rolled back as it was breaking deployment (while it was working fine in the preview env).

The (suspected) cause is that the code element from the values.yaml in gitpod-io is overwritten and not merged in the deployment by the code element in the values.yaml that is generated from the image manifests during deployment, thereby deleting the additional stableVersion property.

We should rather fix/simplify this than forcing workarounds on gitpod-io, so I'll add the very same PR to leave it for fixing in gitpod-com

JanKoehnlein added a commit that referenced this issue Aug 11, 2021
@roboquat roboquat moved this from Awaiting Deployment to In Review in [DEPRECATED] Product Engineering Groundwork Aug 11, 2021
@roboquat roboquat moved this from Awaiting Deployment to In Review in [DEPRECATED] Product Engineering Groundwork Aug 11, 2021
JanKoehnlein pushed a commit that referenced this issue Aug 17, 2021
and removed spaces that cause parse error

Fixes #4965
roboquat pushed a commit that referenced this issue Aug 17, 2021
and removed spaces that cause parse error

Fixes #4965
@roboquat roboquat moved this from In Review to Awaiting Deployment in [DEPRECATED] Product Engineering Groundwork Aug 17, 2021
jakobhero pushed a commit that referenced this issue Aug 17, 2021
and removed spaces that cause parse error

Fixes #4965
MatthewFagan pushed a commit to trilogy-group/gitpod that referenced this issue Dec 18, 2021
and removed spaces that cause parse error

Fixes gitpod-io#4965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
4 participants