Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] desktop support with 1.59 upgrade #5107

Merged
merged 4 commits into from
Aug 19, 2021
Merged

[code] desktop support with 1.59 upgrade #5107

merged 4 commits into from
Aug 19, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Aug 8, 2021

  • /werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

What it does

Important! It depends on #4965

How to test

Switch to latest VS Code in setting before testing above.

Web

Start a new workspace and test following:

  • terminals are preserved and resized properly between window reloads
  • extension host process: check language smartness
  • extension management (installing/uninstalling)
  • install VIM extension to test web extensions
  • test gp open and preview
  • that user data are sync across workspaces as well as on workspace restart, especially for extensions
    • test that extensions from .gitpod.yml are installed without sync
  • settings should not contain any mentions of MS telemetry
  • open the Svelte example in Gitpod, open port 5000 in a new browser tab, set a breakpoint in bundle.js, reload the tab, confirm the app stops in the breakpoint while the original Gitpod tab remains functional.
  • websockets and workers are properly proxied
    • diff editor should be operatable
    • trigger reconnection with window.WebSocket.disconnectWorkspace(), check that old websockets are closed and new opened of the same amount
  • workspace specific commands should work, i.e. F1 → type Gitpod prefix
  • that a PR view is preloaded on the PR url
  • smoke test on Chrome, FF, and Safari on Mac/iPad
Desktop
  • Start the local app
# mac
curl -OL https://ak-remote-ssh.staging.gitpod-dev.com/static/bin/gitpod-local-companion-darwin
# linux
# curl -OL https://ak-remote-ssh.staging.gitpod-dev.com/static/bin/gitpod-local-companion-linux
# windows
# curl -OL https://ak-remote-ssh.staging.gitpod-dev.com/static/bin/gitpod-local-companion-windows

chmod +x ./gitpod-local-companion-darwin
GITPOD_HOST=https://ak-remote-ssh.staging.gitpod-dev.com ./gitpod-local-companion-darwin --mock-keyring
  • Install ms-vscode-remote.remote-ssh and gitpod.gitpod-ui extensions in your local VS Code
  • In local VS Code user settings add:
    "remote.SSH.configFile": "/tmp/gitpod_ssh_config",
    "remote.SSH.defaultExtensions": [
        "gitpod.gitpod-remote-ssh"
    ]
  • Start a workspace: https://ak-remote-ssh.staging.gitpod-dev.com/#github.com/akosyakov/parcel-demo
  • In the ssh targets view, click refresh and select the workspace.
  • A new window should start for Gitpod workspace, check in the extensions view that gitpod.gitpod-remote-ssh is installing.
  • After it is installed, the window should reload with the proper folder.
  • Close the browser workspace window and test:
    • yaml and github pr extensions are installed
    • task terminals are displayed
    • gp/code/git commands are working task terminals as well as in new terminals created by VS Code
    • workspace should not timeout while you are using it, but if you close the window then it should timeout in 2 mins
    • port tunneling works one to one given that 1234 port was not occupied on localhost by something else, check that the local app closed the tunnel for 1234 when the window was opened
    • gitpod commands like stop workspace are there

@akosyakov akosyakov force-pushed the ak/remote_ssh branch 13 times, most recently from 12a0ad5 to 0576ca8 Compare August 10, 2021 12:52
@akosyakov akosyakov changed the title [code] desktop support [code] desktop support with 1.59 upgrade Aug 11, 2021
@akosyakov akosyakov force-pushed the ak/remote_ssh branch 2 times, most recently from 4817197 to 21d1e5d Compare August 11, 2021 09:47
@akosyakov akosyakov marked this pull request as ready for review August 11, 2021 10:02
@akosyakov
Copy link
Member Author

akosyakov commented Aug 16, 2021

/werft run

👍 started the job as gitpod-build-ak-remote-ssh.23

We need some smoke test on this PR for both targets regardless of whether we going with preview or not. Could someone test please? 🙏

@JanKoehnlein
Copy link
Contributor

I get this everytime I start the TS / node example

The 1 extension(s) below, in workspace recommendations have issues: ms-azuretools.vscode-cosmosdb (not found in marketplace)

@JanKoehnlein
Copy link
Contributor

In the local VS Code

  • gp open and code commands only work in new terminals, not in the task terminals

@akosyakov
Copy link
Member Author

akosyakov commented Aug 18, 2021

gp open and code commands only work in new terminals, not in the task terminals

Let's file an issue and add the local crew backlog. We can tackle this late.

I can only work with latest Gitpod Code Server running in the same workspace.

@JanKoehnlein
Copy link
Contributor

JanKoehnlein commented Aug 19, 2021

/werft run

👍 started the job as gitpod-build-ak-remote-ssh.28

@JanKoehnlein
Copy link
Contributor

JanKoehnlein commented Aug 19, 2021

/werft run

👍 started the job as gitpod-build-ak-remote-ssh.29

@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1ab88f0f8f5da3206607f3ecf4a69a09b64ae451

@akosyakov
Copy link
Member Author

/approve

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, JanKoehnlein

Associated issue: #4918

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 24c91af into main Aug 19, 2021
@roboquat roboquat deleted the ak/remote_ssh branch August 19, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants