Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the revert of "[ide] added VS Code "Insiders" IDE variant" #5147

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

JanKoehnlein
Copy link
Contributor

This reverts commit 7826291.

Fixes #4965

@JanKoehnlein
Copy link
Contributor Author

Needs deployment process to be fixed in gitpod-com, see #4965 (comment)

/hold

@jankeromnes
Copy link
Contributor

jankeromnes commented Aug 13, 2021

Removing the automatic review requests, as they don't seem relevant. Please feel free to re-request a review if needed! 😊

@JanKoehnlein
Copy link
Contributor Author

/unhold

@JanKoehnlein JanKoehnlein force-pushed the jankoehnlein/code-preview-version-4965 branch 2 times, most recently from 846504e to 63659c9 Compare August 17, 2021 09:57
@roboquat roboquat added size/L and removed size/XS labels Aug 17, 2021
@JanKoehnlein JanKoehnlein force-pushed the jankoehnlein/code-preview-version-4965 branch from 63659c9 to f76d032 Compare August 17, 2021 09:58
@roboquat roboquat added size/M and removed size/L labels Aug 17, 2021
and removed spaces that cause parse error

Fixes #4965
@JanKoehnlein JanKoehnlein force-pushed the jankoehnlein/code-preview-version-4965 branch from f76d032 to 88a8772 Compare August 17, 2021 10:43
@JanKoehnlein
Copy link
Contributor Author

/approve

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 41a30ff882b87dcf399f30662a9074efd9aae809

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, JanKoehnlein

Associated issue: #4965

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit de5ee83 into main Aug 17, 2021
@roboquat roboquat deleted the jankoehnlein/code-preview-version-4965 branch August 17, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[code] preview version for testing
4 participants