Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitlab] Accept '#' sign in branches / context URLs #5362

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

corneliusludmann
Copy link
Contributor

@corneliusludmann corneliusludmann commented Aug 24, 2021

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was in the neighborhood and tried this in action! Works well for both GL and GH. ✔️

"defaultBranch": "master",
"private": false
},
"title": "gp-test-group/gp-test-project - feature/#123-issue"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Shall we move this group under gitpod-io group?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely would love it if we would create proper repos for all these (and the GH) tests under the gitpod-io group. For the sake of MVP what do you think of creating an issue for that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely would love it if we would create proper repos for all these (and the GH) tests under the gitpod-io group. For the sake of MVP what do you think of creating an issue for that?

💯 x 💯

@corneliusludmann
Copy link
Contributor Author

/auto-cc

@roboquat roboquat requested a review from geropl September 2, 2021 13:15
@corneliusludmann corneliusludmann removed the request for review from svenefftinge September 2, 2021 13:15
@geropl
Copy link
Member

geropl commented Sep 6, 2021

/werft run

👍 started the job as gitpod-build-clu-workspace-creation-5129.1

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works: 👍

@roboquat
Copy link
Contributor

roboquat commented Sep 6, 2021

LGTM label has been added.

Git tree hash: 872cf4bc4684e8653b85ee5f1adcc9fea8e76754

@roboquat
Copy link
Contributor

roboquat commented Sep 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl

Associated issue: #5129

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit f167ce1 into main Sep 6, 2021
@roboquat roboquat deleted the clu/workspace-creation-5129 branch September 6, 2021 14:22
@gtsiolis gtsiolis mentioned this pull request Sep 16, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace creation erroring out on special character #
4 participants