-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include GitLab subgroups #6546
Include GitLab subgroups #6546
Conversation
bb217e9
to
ca9be09
Compare
Multiple subgroups can be nested (docs). |
@svenefftinge Thanks for this! |
/hold |
12f6c50
to
3f227b4
Compare
/unhold Ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX works as expected, @laushinka! 🔮
Approving to unblock merging but holding
/hold
}); | ||
} | ||
|
||
@test public parseSubgroupFourLevels() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Thanks for adding these tests here, @laushinka! 🌟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @svenefftinge for the reminder to write more tests :)
|
||
@test public parseSubgroupFourLevels() { | ||
const testUrl = RepoURL.parseRepoUrl( | ||
"https://gitlab.com/hello-group/my-subgroup/my-sub-subgroup/my-sub-sub-subgroup/my-sub-sub-sub-subgroup/my-cool-project.git") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue(non-blocking): Cross-posting from #5362 (comment) to bring this up again, although sounds ok to leave this out of the scope of this PR, in case we'd like to make plan any action:
Shall we move this group under
gitpod-io
group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to answer but I'm not sure I know what this question or this context means, even after reading the issue. Maybe something I can ask about in the next team call? Also cc-ing @JanKoehnlein in case he has context.
LGTM label has been added. Git tree hash: 9e8c123b4e2aaad7aaa0a6aad16178f93df67796
|
Doesn't work for me. I created group0 and group1 inside and projects group0/bar and group0/group1/Foo. The latter can be prebuilt, the former can't. Could be related to the fact that GitLab changed the URL of group0 to g2506 to avoid collision. |
😵 @JanKoehnlein show in a call? |
question: @JanKoehnlein did use the same example project + commit for the two projects? Cc @laushinka issue(non-blocking): I could not prebuild the second project when using the same commit, but this is a different issue related to prebuilds and out of the scope of this PR, right? Got the following error:
|
We just found out that the issues are likely connected to the fact that my project was called |
@JanKoehnlein Just pushed. Please help test again with your test cases 🙏🏽 |
624a02e
to
284d442
Compare
/lgtm Should we also remove |
LGTM label has been added. Git tree hash: 204efbd1b021ee8df403901e61793a4449d714f6
|
@JanKoehnlein Did the prebuilds work now for your projects? I had issues still with a few of them, but not sure if it's because of the specific repos/configs as Chris mentioned in this conversation.
Good point. |
Fixes #6068
284d442
to
fb07348
Compare
/lgtm |
LGTM label has been added. Git tree hash: 9e4daa0e7bb0ba5d55de6466f05fab50e41b1a05
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gtsiolis, JanKoehnlein Associated issue: #6068 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Fixes #6068
Description
This PR allows GitLab projects in subgroups and nested subgroups to be accessible. This PR also includes additional fixes related to the GitLab slug issue.
Related Issue(s)
Fixes #6068
How to test
Release Notes
Documentation