Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code] apply installation options for extensions from vsix #5417

Merged
merged 1 commit into from
Aug 30, 2021
Merged

[code] apply installation options for extensions from vsix #5417

merged 1 commit into from
Aug 30, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Aug 27, 2021 •
edited
Loading

  • /werft with-clean-slate-deployment

What it does

Change in Gitpod Code: gitpod-io/openvscode-server@10009f5

How to test

@roboquat roboquat requested a review from aledbf August 27, 2021 12:16
@akosyakov akosyakov changed the title [code] fix race between extracting ext and writing initial metadata [code] fix reading/writing initial extension metadata race Aug 27, 2021
@akosyakov
Copy link
Member Author

/hold

since we should merge #5329 first

@akosyakov akosyakov force-pushed the akosyakov/code-worspaces-extensions-5405 branch from 49d320c to 134537c Compare August 27, 2021 12:42
@akosyakov akosyakov marked this pull request as ready for review August 27, 2021 12:42
@akosyakov
Copy link
Member Author

/unhold

@akosyakov akosyakov force-pushed the akosyakov/code-worspaces-extensions-5405 branch from 134537c to f0c7ee7 Compare August 29, 2021 08:19
@jeanp413
Copy link
Member

jeanp413 commented Aug 29, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-akosyakov-code-worspaces-extensions-5405.3

@jeanp413
Copy link
Member

@akosyakov the extensions still are marked as synced
Screenshot from 2021-08-29 18-52-27

@akosyakov akosyakov force-pushed the akosyakov/code-worspaces-extensions-5405 branch from f0c7ee7 to f756c05 Compare August 30, 2021 06:11
@akosyakov akosyakov changed the title [code] fix reading/writing initial extension metadata race [code] apply installation options for extensions from vsix Aug 30, 2021
@akosyakov
Copy link
Member Author

It should be good now. @JanKoehnlein Could you help to review it? I need also get through 2 other PRs today: one disable VS Code Desktop for stable, and another to configure stable to use latest with these 2 PRs.

@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 30, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d1fb8aca522fba3c993e97f8f32eca050502ec7e

@akosyakov
Copy link
Member Author

/approve

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, JanKoehnlein

Associated issue: #5405

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 057c424 into main Aug 30, 2021
@roboquat roboquat deleted the akosyakov/code-worspaces-extensions-5405 branch August 30, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf Awaiting requested review from aledbf

Assignees

@JanKoehnlein JanKoehnlein

@jeanp413 jeanp413

Labels
approved size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[code] worspaces extensions installed as sync
4 participants
@akosyakov @jeanp413 @JanKoehnlein @roboquat