Fix bogus http status code for payload too large error

[jeanp413]

Fixes #5087

[svenefftinge]

Hey @jeanp413 👋 Do we have an issue for this that you can link to or can you please share more info on why this change is good?

[jeanp413]

Sure I'll update the title and description. I created this yesterday really quickly to play around with gitpod in my meeting with Anton.

[jeanp413]

/werft run

👍 started the job as gitpod-build-jeanp413-bogus-http-status-code-5087.1

[laushinka]

Sure I'll update the title and description. I created this yesterday really quickly to play around with gitpod in my meeting with Anton.

I changed the reviewer to @akosyakov since he has context.

[akosyakov]

/werft run

👍 started the job as gitpod-build-jeanp413-bogus-http-status-code-5087.4

[akosyakov]

It works, but VS Code gives misleading errors:

We need to change 100Kb to 1Mb here: https://github.com/gitpod-io/vscode/blob/44f54ed0017685f29b564ee36c79907afd5c090e/src/vs/workbench/contrib/userDataSync/browser/userDataSync.ts#L331-L331

[akosyakov]

/werft run

👍 started the job as gitpod-build-jeanp413-bogus-http-status-code-5087.7

[akosyakov]

/hold

@jeanp413 Could you clean up the history please to remove unnecessary changes in regards to trying different sizes? You can type /unhold afterwards to merge.

[akosyakov]

/lgtm

[roboquat]

LGTM label has been added.

Git tree hash: ec98285dfcc513c8d083da39adc21be1e9a20f5b

[akosyakov]

/assign @csweichel

[roboquat]

@akosyakov:

In response to this:

/lgtm

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[roboquat]

LGTM label has been added.

Git tree hash: ec98285dfcc513c8d083da39adc21be1e9a20f5b

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, svenefftinge

Associated issue: #5087

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/ide/OWNERS [akosyakov]
• components/server/OWNERS [svenefftinge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment