[t&p] add workspaces to teams #5555
Conversation
roboquat
added
size/L
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
/werft run 👍 started the job as gitpod-build-se-workspace-for-teams.1 |
svenefftinge
force-pushed
the
se/workspace-for-teams
branch
from
bf79d57
to
f313efb
Compare
|
I'm concerned splitting the workspace lists like this will confuse users. They might look for their workspaces in the wrong place. @gtsiolis @AlexTugarev Can you try and share your thoughts on this? The main idea was to better communicate which workspaces are accounted to which (account/team). Some thoughts I had are:
|
|
That's an interesting view. Discoverability of workspaces wasn't nothing I thought of. Now that you picked that up, I think switching context (e.g. searching a workspace in another project) might be more difficult. The easiest way would still be to use a search filter in a single list of workspaces. Perhaps adding a column |
|
Thinking further, I'd like to raise another concern with "team workspaces". Correct me if I'm wrong, but does this mean, that another team member may restart one of my workspaces? Iff so...
|
|
/werft run 👍 started the job as gitpod-build-se-workspace-for-teams.4 |
@AlexTugarev The idea was to group workspaces by team and keep ownership and access only to each user as is. ❗ 🧀 🧀 🧀 🧀
@svenefftinge I think keeping the global list we have now is good for improving (workspace) discoverability and avoid disrupting existing user flows. 🥝 🥝 🥝 🥝
🍊 🍊 🍊 🍊
@svenefftinge We could re-introduce a New Workspace button (primary) on the project page (Branches) which is missing now (❗) and couple it with a View Workspaces button (secondary) that redirects to the global workspaces list filtered down to the
🍋 🍋 🍋 🍋 Although out of the scope of these changes, merging active and all workspaces could help. |
Sounds and looks good to me 👍
💯 |
svenefftinge
force-pushed
the
se/workspace-for-teams
branch
from
f313efb
to
1f014cb
Compare
|
/werft run 👍 started the job as gitpod-build-se-workspace-for-teams.6 |
|
/werft run 👍 started the job as gitpod-build-se-workspace-for-teams.7 |
|
/werft run 👍 started the job as gitpod-build-se-workspace-for-teams.8 |
|
/werft run 👍 started the job as gitpod-build-se-workspace-for-teams.9 |
svenefftinge
force-pushed
the
se/workspace-for-teams
branch
from
1f014cb
to
34cd0d6
Compare
|
/werft run 👍 started the job as gitpod-build-se-workspace-for-teams.11 |
| inactiveWorkspaces.length === 0 ? null : | ||
| <Item className="w-full bg-gray-50 py-3 px-3"> | ||
| <ItemField className=" flex flex-col"> | ||
| <div className="text-gray-400 text-sm text-center">Unpinned workspaces that have been inactive for more than 14 days will be automatically deleted. <a className="gp-link" href="https://www.gitpod.io/docs/life-of-workspace/#garbage-collection">Learn more</a></div> |
There was a problem hiding this comment.
issue: Could we also make the background on the default state for the dark theme darker here like bg-gray-800, besides removing the hover state (see https://github.com/gitpod-io/gitpod/pull/5555/files#r715033220)? Sounds good also as a follow up issue as this affects the Item List component. 😬
| BEFORE | AFTER |
|---|---|
 |
 |
|
/werft run 👍 started the job as gitpod-build-se-workspace-for-teams.15 |
svenefftinge
force-pushed
the
se/workspace-for-teams
branch
from
7a1b41c
to
ad842bd
Compare
svenefftinge
force-pushed
the
se/workspace-for-teams
branch
from
bb75a76
to
545d11d
Compare
|
This isn't a big thing, but for personal and not project-tagged workspaces I'd expect a different message/action than To be fixed in https://github.com/gitpod-io/gitpod/compare/545d11d4904aa6dc4057926fc4830dea22a2b905..714099e0b4f169f8e38fa95890651ff5dd8cc0d3 |
svenefftinge
force-pushed
the
se/workspace-for-teams
branch
from
545d11d
to
714099e
Compare
svenefftinge
force-pushed
the
se/workspace-for-teams
branch
from
714099e
to
b22f470
Compare
|
/lgtm Verified that it works as advertised 👍🏻 /hold just in case there are more minor tweaks to do |
|
LGTM label has been added. Git tree hash: 51d6f9018f96535cb0567da074f291a8135feb47
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexTugarev Associated issue: #4921 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
gtsiolis
added
component: dashboard
feature: teams and projects [DEPRECATED]
This PR adds a workspaces tab to teams and projects, showing only the relevant workspaces.
Also under the individual account no workspaces that are created in the context of teams are shown anymore.
This PR also removes active and inactive filter and instead shows both at once. Finally, a few layout things have been aligned based on the design from @gtsiolis.
fixes #4921
How to test
login, create team(s) and create projects below. Now start workspaces for different projects and also non-project contexts.
Verify that the workspaces are shown properly.