Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux(dashboard): import existing projects by prefixing #5806

Closed
wants to merge 1 commit into from
Closed

Conversation

ghuntley
Copy link
Contributor

@ghuntley ghuntley commented Sep 22, 2021

Description

Watch https://youtu.be/x19DetWAsVA?t=268

@gtsiolis after your thoughts here about plugging the browser extension (and saying folks should install it) in this paragraph as well and explaining that browser extension is the correct/primary way to utilise Gitpod. Not sure what words to use but let's discuss.

Related Issue(s)

How to test

Release Notes

NONE

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ghuntley! Added one comment below. Let me know what you think. 🏀

@@ -134,7 +134,7 @@ export default class Workspaces extends React.Component<WorkspacesProps, Workspa
<div className="px-6 py-3 flex justify-between space-x-2 text-gray-400 border-t border-gray-200 dark:border-gray-800 h-96">
<div className="flex flex-col items-center w-96 m-auto">
<h3 className="text-center pb-3 text-gray-500 dark:text-gray-400">No Active Workspaces</h3>
<div className="text-center pb-6 text-gray-500">Prefix any git repository URL with gitpod.io/# or create a new workspace for a recently used project. <a className="gp-link" href="https://www.gitpod.io/docs/getting-started/">Learn more</a></div>
<div className="text-center pb-6 text-gray-500">Import your existing projects by prefixing any git repository URL with gitpod.io/# or create a new workspace for a recently used project. <a className="gp-link" href="https://www.gitpod.io/docs/getting-started/">Learn more</a></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This change could be confusing once we ship Teams & Projects next month[1] as this will not actually import a project but only use the repository as a context. This could get more confusing as we're planning to add workspaces under personal accounts, teams, and projects (see #5555 (comment)). ❗

thought: We could consider having a way to prompt users to add repositories as projects on a team or their personal account while using the prefixed URL before opening the workspace but still this could be available only if they have proper write permissions so this change wouldn't be applicable for everyone.

suggestion: I'd suggest to hold this back this back until we ship Teams & Projects, rephrase it, or close it to avoid any confusion. What do you think?

Cc @svenefftinge because relevant diff.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes: importing a project != starting a workspace on a repo

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign svenefftinge after the PR has been reviewed.
You can assign the PR to them by writing /assign @svenefftinge in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 24, 2021

@gtsiolis after your thoughts here about plugging the browser extension (and saying folks should install it) in this paragraph as well and explaining that browser extension is the correct/primary way to utilise Gitpod. Not sure what words to use but let's discuss.

Promoting the browser extension within the dashboard sounds great!

FWIW, we did have a relevant tips on the loading screen[1][2] before the dashboard redesign, back in March, which we could consider adding back. 🔖

Besides the loading screen, a one-time dismissible notification within the dashboard could be useful. This could be added using a) a toast notification (see #3530), b) a different in-product notification (see relevant discussion (internal) cc @JohannesLandgraf), or c) an updated what's new entry once any upcoming changes to the browser extension are worth adding there.

Dot indicator (Early Draft) What's New (Early Draft)
Collapsed Expanded

@stale
Copy link

stale bot commented Oct 8, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 8, 2021
@ghuntley
Copy link
Contributor Author

How shall we proceed?

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Oct 11, 2021
@stale
Copy link

stale bot commented Oct 21, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 21, 2021
@stale stale bot closed this Oct 26, 2021
@AlexTugarev AlexTugarev deleted the gh/prefix branch December 8, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: stale This issue/PR is stale and will be closed soon release-note-none size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants