Truncate commit message on branches and prebuilds #6074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtsiolis
added
component: dashboard
type: improvement
gtsiolis
commented
Oct 6, 2021
| <div> | ||
| <div className="text-base text-gray-500 dark:text-gray-50 font-medium mb-1">{shortCommitMessage(p.info.changeTitle)}</div> | ||
| <div className="truncate"> | ||
| <div className="text-base text-gray-500 dark:text-gray-50 font-medium mb-1 truncate">{shortCommitMessage(p.info.changeTitle)}</div> |
There was a problem hiding this comment.
thought: Not sure if I'm missing something here but this works better when using the truncate class on both elements. 🤷
|
@geropl could you take a look at this small change when you're free? priority: Low 🔅 |
|
@gtsiolis Sorry for this taking so long. I will try to improve my review workflow with the next free slot I can find 🙇 |
|
LGTM label has been added. Git tree hash: e48d7356e043c2fb5cba2dd257ba68bd05da363f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geropl Associated issue: #5335 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will truncate the commit message on branches and prebuilds.
Related Issue(s)
Fix #5335
Screenshots
How to test
Release Notes