[database]: allow configuring of db username with DB_USERNAME envvar #6171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but I'd rather have a second pair of eyes look at that /cc @AlexTugarev |
|
/lgtm thanks for the reasonable explanation. |
|
LGTM label has been added. Git tree hash: 3ba14277adabbc0f2d7835e2bc95a3c1eba4ab41
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexTugarev Associated issue: #5508 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Have confirmed this now works as expected in Azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the DB usernames are all hard-coded to
gitpod. This prevents usage with certain DB instances that cannot use that notation (eg, Azure which enforces usernames to be<username>@<hostname>). This allows configuration of the DB username with an envvar.DB_USERNAMEis used as it's already supported by thedatabase-waitercomponent.Related Issue(s)
Fixes #5508
How to test
Release Notes
Documentation
https://github.com/gitpod-io/website/issues/1065