Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: create a configmap with a simplified installation manifest #6591

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Nov 6, 2021

Description

Uninstallation can be invoked by kubectl get configmaps gitpod-app -o jsonpath='{.data.app\.yaml}' | kubectl delete -f -

This also tidies up the sort function - it's gotten a bit bloated so it's doing about 3 different things. This separates out each part into individual parts (SOLID FTW)

Have also renamed the sorter.go file to display.go as it's not just sorting in there now, which might get confusing to new eyes

Related Issue(s)

Fixes #6290

How to test

Deploy a version of the app, uninstall using the above command

Release Notes

Create config map to allow uninstallation of app

Documentation

@roboquat roboquat added release-note team: workspace Issue belongs to the Workspace team size/L labels Nov 6, 2021
@codecov
Copy link

codecov bot commented Nov 6, 2021

Codecov Report

Merging #6591 (cb201bf) into main (335215f) will decrease coverage by 2.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #6591      +/-   ##
========================================
- Coverage   8.17%   6.16%   -2.01%     
========================================
  Files         14      12       -2     
  Lines       1211    1086     -125     
========================================
- Hits          99      67      -32     
+ Misses      1109    1018      -91     
+ Partials       3       1       -2     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 6.16% <0.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
installer/pkg/common/display.go 0.00% <0.00%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 335215f...cb201bf. Read the comment docs.

This can be used to uninstall the application
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"APIService",
}

type RuntimeObject struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference: we need to reign this back in; not export this in the future. Having our own version of what's essentially runtime.Object doesn't bode well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, agreed. I don't want this used for anything else

@roboquat
Copy link
Contributor

roboquat commented Nov 8, 2021

LGTM label has been added.

Git tree hash: 2661f7e774ea83841236d2d0ea1e0cc5578251f2

@roboquat
Copy link
Contributor

roboquat commented Nov 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #6290

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit d1fff68 into main Nov 8, 2021
@roboquat roboquat deleted the sje/installer-configmap branch November 8, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Installer]: uninstallation
3 participants