[Werft] - Update build to support Installer #6827

kylos101 · 2021-11-22T02:19:46Z

Description

[Werft] - Update build to support Installer

Related Issue(s)

Fixes #6808

How to test

werft run (runs Installer) or werft run with-helm (runs helm)

werft run with-clean-slate-deployment (will do clean-up, even for helm, and then install with Installer)

werft run with-clean-slate-deployment with-helm (will do clean-up, even for Installer, and then run Helm)

werft run ws-feature-flags=registry-facade (sets flag)

with-observability and with-payment have not been implemented, if needed please use with-helm too.

Meta considerations

Implemented:

Analytics
License / no-license
Feature flags

Not implemented:

with-payment integration for chargebees

Release Notes

1. [installer] Add a namespace for the cert-manager self-signing issuer so it can be uninstalled using the configmap.
2. [installer] Set EnableLocalApp to true by default.

Documentation

kylos101 · 2021-11-22T02:20:51Z

@ArthurSens , FYI, here is the draft PR for the Werft job changes.

kylos101 · 2021-11-22T02:22:04Z

/werft run with-helm

kylos101 · 2021-11-22T02:22:50Z

/werft run with-helm

👍 started the job as gitpod-build-kyleb-installer-werft.6

kylos101 · 2021-11-24T01:34:21Z

/status in-progress

kylos101 · 2021-11-25T05:33:49Z

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-kyleb-installer-werft.55

kylos101 · 2021-11-25T12:06:14Z

/werft run

👍 started the job as gitpod-build-kyleb-installer-werft.63

kylos101 · 2021-11-26T13:38:22Z

/werft run

👍 started the job as gitpod-build-kyleb-installer-werft.64

kylos101 · 2021-11-26T15:21:34Z

/werft run with-helm with-clean-slate-deployment

👍 started the job as gitpod-build-kyleb-installer-werft.65

codecov · 2021-11-26T21:11:52Z

Codecov Report

Merging #6827 (bc032cd) into main (2631195) will decrease coverage by 1.67%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main   #6827      +/-   ##
========================================
- Coverage   7.44%   5.76%   -1.68%     
========================================
  Files         15      13       -2     
  Lines       1330    1162     -168     
========================================
- Hits          99      67      -32     
+ Misses      1228    1094     -134     
+ Partials       3       1       -2

Flag	Coverage Δ
components-local-app-app-linux-amd64	`?`
components-local-app-app-linux-arm64	`?`
components-local-app-app-windows-386	`?`
components-local-app-app-windows-amd64	`?`
components-local-app-app-windows-arm64	`?`
installer-raw-app	`5.76% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2631195...bc032cd. Read the comment docs.

kylos101 · 2021-11-27T00:04:17Z

a593de6 also resolves #6851

iQQBot · 2021-11-27T09:09:10Z

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-kyleb-installer-werft.87

kylos101

@mrsimonemms could I get a code review from you on the Go changes in this PR? They're mostly related to the Installer, and getting workloads to pass the PSP (which I bumped into in core-dev).

kylos101 · 2021-12-06T12:58:59Z

installer/pkg/components/cluster/certmanager.go

-				Labels: common.DefaultLabels(Component),
+				Name:      caIssuer,
+				Labels:    common.DefaultLabels(Component),
+				Namespace: ctx.Namespace,


kubectl delete was throwing an error w/o the Issuer being namespaced.

kylos101 · 2021-12-06T13:00:02Z

.werft/util/uninstall-gitpod.sh

+fi
+
+echo "Removing Gitpod in namespace ${NAMESPACE}"
+kubectl get configmap gitpod-app -n "${NAMESPACE}" -o jsonpath='{.data.app\.yaml}' | kubectl delete -f -


This shellscript is necessary because the kubectl delete was getting a no resources found in the TypeScript file. In other words, this is a workaround.

Understood. Would be awesome if the installer had such a delete feature itself.

Hey @geropl what would the use case be for that? I ask because we also have with-clean-slate-deployment=true - which removes either Helm or Installer, and then installs with the Installer if no with-helm was specified. If with-helm=true was specified, it'll clean then install with Helm.

Or do you mean have the installer connect to the Kubernetes installation, and remove Gitpod itself?

Or do you mean have the installer connect to the Kubernetes installation, and remove Gitpod itself?

Sorry for not being clear: yes. IMO the installer should be able to completly remove everything it added. We already have the gitpod-app Configmap which contains everything required (although only for the last render run).

installer/pkg/components/database/incluster/objects.go

installer/pkg/components/database/incluster/rolebinding.go

installer/pkg/components/image-builder-mk3/clusterrole.go

installer/pkg/components/rabbitmq/constants.go

installer/pkg/components/registry-facade/clusterrole.go

installer/pkg/components/registry-facade/podsecuritypolicy.go

installer/pkg/components/server/configmap.go

kylos101 · 2021-12-09T15:36:54Z

Thank you for the approval, @mads-hartmann ! Let's leave the hold applied and wait to hear back from Team Meta.

@gitpod-io/engineering-meta may we ask for a review from you as well? You'll notice there is an "escape hatch", where you can continue to use with-helm, but, the installer will be the default going forward.

kylos101 · 2021-12-09T16:40:42Z

Also, once the meta review is finished, I would like to squash this PR, so let's leave the hold until then. 🙏

geropl · 2021-12-10T08:42:14Z

@kylos101 Starting to review now 👀

geropl · 2021-12-10T13:37:56Z

.werft/build.ts

+        const CONTAINERD_RUNTIME_DIR = "/var/lib/containerd/io.containerd.runtime.v2.task/k8s.io";
+
+        // get some values we need to customize the config and write them to file
+        exec(`yq r ./.werft/values.dev.yaml components.server.blockNewUsers \


I understand that this is a concession to the interface problem around values.dev.yaml for as long as we have two ways to install on devstaging. I really hope we can get rid of this, soon. :slighty_smiling_face:

geropl · 2021-12-10T13:46:55Z

.werft/post-process.sh

+   if [[ "server-config" == "$NAME" ]] && [[ "$KIND" == "ConfigMap" ]]; then
+      WORK="overrides for $NAME $KIND"
+      echo "$WORK"
+      touch /tmp/"$NAME"overrides.yaml


After reading in detail, this is less stuff than I feared. It's a bit noisy (not necessarily the bad kind) but most of it is connected to the devstaging setup. 👍

geropl

Nice PR @kylos101! Thx for all the explanation :-)

Keeping the hold in case you want to time/announce the merge.

kylos101 · 2021-12-10T19:43:40Z

Hi @mrsimonemms and @iQQBot , I had to do a follow-up commit which removed the L G T M label. May I ask for a follow-up code review so we can add L G T M label back? Also, please leave the hold label on, as I haven't squashed yet.

Please review:

@iQQBot I rebased from main in 6ceb88e, resolving conflicts from cleanup k3s cluster in core-dev #7136.
@mrsimonemms I had to address an issue because core-dev / k8s is 1.20, maybe introduced by [installer]: bump rabbitmq chart to remove deprecated kube api #7041, which I handled using post processing in 790907e
- if you kubectl api-resources | grep disruption, you'll see we're not on the same version as 1.21

And if you approve, then we can add the L G T M label back. Thank you for your help!

kylos101 · 2021-12-11T01:54:56Z

@geropl could I ask you to peek at 1bebdde and 426f82a? I made a couple changes to ensure folks with existing Helm preview environments continue to have a nice experience, and can still opt into using the installer...but only if they specify specify with-clean-slate-deployment=true. Thank you!

csweichel · 2021-12-13T08:50:03Z

Hey. Awesome to this about to be merged - excellent effort everyone!

This is a lot of commits (43). @kylos101 could you please go through and squash commits so that the remaining commit history makes sense once it's on main?

The Installer is the default for new Preview Environments. Preview Environments powered by Helm can switch to the Installer if 'with-clean-slate-deployment=true' is specified. Folks can continue using Helm if 'with-helm=true' is specified. Co-authored-by: Christian Weichel <chris@gitpod.io>

kylos101 · 2021-12-13T14:42:43Z

Hey @csweichel all set in 7ac89a8.

Helm build here (which is very much like anyone currently using Helm will see):
https://werft.gitpod-dev.com/job/gitpod-build-kyleb-installer-werft.222

I'll do a follow-on where it removes the Helm install, and then uses the Installer, then we should be 🟩 .

kylos101 · 2021-12-13T14:47:44Z

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-kyleb-installer-werft.223

csweichel · 2021-12-13T17:13:20Z

/lgtm

roboquat · 2021-12-13T17:13:24Z

LGTM label has been added.

Git tree hash: 481c6b9fe7291e35530751d728c5e0a86bae1a94

roboquat · 2021-12-13T17:13:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, geropl, kylos101, mads-hartmann

Associated issue: #6808

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [csweichel,geropl]
~~installer/OWNERS~~ [csweichel]
~~installer/pkg/components/image-builder-mk3/OWNERS~~ [csweichel]
~~installer/pkg/components/registry-facade/OWNERS~~ [csweichel]
~~installer/pkg/components/server/OWNERS~~ [geropl]
~~installer/pkg/components/ws-daemon/OWNERS~~ [csweichel]
~~installer/pkg/components/ws-scheduler/OWNERS~~ [csweichel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kylos101 · 2021-12-13T19:34:26Z

/unhold

This PR has been squashed.
I tested one last time with Helm.
I tested one last time with the Installer.

roboquat added do-not-merge/work-in-progress do-not-merge/release-note-label-needed size/M labels Nov 22, 2021

roboquat added size/L size/XL and removed size/M size/L labels Nov 22, 2021

kylos101 mentioned this pull request Nov 25, 2021

[Werft] - Update build to support Installer #6808

Closed

18 tasks

kylos101 mentioned this pull request Nov 26, 2021

[installer] default for enableLocalApp #6851

Closed

roboquat added the team: workspace Issue belongs to the Workspace team label Nov 26, 2021

kylos101 force-pushed the kyleb/installer-werft branch from 0c3cddb to 1d6da80 Compare November 29, 2021 15:46

roboquat added size/XXL team: webapp Issue belongs to the WebApp team and removed size/XL labels Nov 29, 2021

kylos101 force-pushed the kyleb/installer-werft branch from ba6eba3 to 68819ae Compare December 3, 2021 19:03

kylos101 commented Dec 6, 2021

View reviewed changes

roboquat added release-note and removed do-not-merge/release-note-label-needed labels Dec 7, 2021

kylos101 marked this pull request as ready for review December 7, 2021 04:45

iQQBot mentioned this pull request Dec 10, 2021

[ide] Serve IDE logos independently of the dashboard #7141

Merged

geropl reviewed Dec 10, 2021

View reviewed changes

geropl approved these changes Dec 10, 2021

View reviewed changes

roboquat assigned geropl Dec 10, 2021

kylos101 force-pushed the kyleb/installer-werft branch from 5705e38 to 6ceb88e Compare December 10, 2021 16:42

roboquat removed the lgtm label Dec 10, 2021

kylos101 force-pushed the kyleb/installer-werft branch from 426f82a to 7ac89a8 Compare December 13, 2021 14:38

roboquat assigned csweichel Dec 13, 2021

roboquat added the lgtm label Dec 13, 2021

roboquat added the approved label Dec 13, 2021

roboquat removed the do-not-merge/hold label Dec 13, 2021

roboquat merged commit a9efe45 into main Dec 13, 2021

roboquat deleted the kyleb/installer-werft branch December 13, 2021 19:34

roboquat added the deployed: webapp Meta team change is running in production label Dec 14, 2021

roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Werft] - Update build to support Installer #6827

[Werft] - Update build to support Installer #6827

kylos101 commented Nov 22, 2021 •

edited

Loading

kylos101 commented Nov 22, 2021

kylos101 commented Nov 22, 2021 •

edited

Loading

kylos101 commented Nov 22, 2021 •

edited by werft-gitpod-dev-com bot

Loading

kylos101 commented Nov 24, 2021

kylos101 commented Nov 25, 2021 •

edited by werft-gitpod-dev-com bot

Loading

kylos101 commented Nov 25, 2021 •

edited by werft-gitpod-dev-com bot

Loading

kylos101 commented Nov 26, 2021 •

edited by werft-gitpod-dev-com bot

Loading

kylos101 commented Nov 26, 2021 •

edited by werft-gitpod-dev-com bot

Loading

codecov bot commented Nov 26, 2021 •

edited

Loading

kylos101 commented Nov 27, 2021

iQQBot commented Nov 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading

kylos101 left a comment

kylos101 Dec 6, 2021

kylos101 Dec 6, 2021

geropl Dec 10, 2021

kylos101 Dec 10, 2021 •

edited

Loading

kylos101 Dec 10, 2021

geropl Dec 10, 2021

kylos101 commented Dec 9, 2021

kylos101 commented Dec 9, 2021

geropl commented Dec 10, 2021

geropl Dec 10, 2021

geropl Dec 10, 2021 •

edited

Loading

geropl left a comment

kylos101 commented Dec 10, 2021 •

edited

Loading

kylos101 commented Dec 11, 2021

csweichel commented Dec 13, 2021 •

edited

Loading

kylos101 commented Dec 13, 2021

kylos101 commented Dec 13, 2021 •

edited by werft-gitpod-dev-com bot

Loading

csweichel commented Dec 13, 2021

roboquat commented Dec 13, 2021

roboquat commented Dec 13, 2021

kylos101 commented Dec 13, 2021

[Werft] - Update build to support Installer #6827

[Werft] - Update build to support Installer #6827

Conversation

kylos101 commented Nov 22, 2021 • edited Loading

Description

Related Issue(s)

How to test

Meta considerations

Release Notes

Documentation

kylos101 commented Nov 22, 2021

kylos101 commented Nov 22, 2021 • edited Loading

kylos101 commented Nov 22, 2021 • edited by werft-gitpod-dev-com bot Loading

kylos101 commented Nov 24, 2021

kylos101 commented Nov 25, 2021 • edited by werft-gitpod-dev-com bot Loading

kylos101 commented Nov 25, 2021 • edited by werft-gitpod-dev-com bot Loading

kylos101 commented Nov 26, 2021 • edited by werft-gitpod-dev-com bot Loading

kylos101 commented Nov 26, 2021 • edited by werft-gitpod-dev-com bot Loading

codecov bot commented Nov 26, 2021 • edited Loading

Codecov Report

kylos101 commented Nov 27, 2021

iQQBot commented Nov 27, 2021 • edited by werft-gitpod-dev-com bot Loading

kylos101 left a comment

Choose a reason for hiding this comment

kylos101 Dec 6, 2021

Choose a reason for hiding this comment

kylos101 Dec 6, 2021

Choose a reason for hiding this comment

geropl Dec 10, 2021

Choose a reason for hiding this comment

kylos101 Dec 10, 2021 • edited Loading

Choose a reason for hiding this comment

kylos101 Dec 10, 2021

Choose a reason for hiding this comment

geropl Dec 10, 2021

Choose a reason for hiding this comment

kylos101 commented Dec 9, 2021

kylos101 commented Dec 9, 2021

geropl commented Dec 10, 2021

geropl Dec 10, 2021

Choose a reason for hiding this comment

geropl Dec 10, 2021 • edited Loading

Choose a reason for hiding this comment

geropl left a comment

Choose a reason for hiding this comment

kylos101 commented Dec 10, 2021 • edited Loading

kylos101 commented Dec 11, 2021

csweichel commented Dec 13, 2021 • edited Loading

kylos101 commented Dec 13, 2021

kylos101 commented Dec 13, 2021 • edited by werft-gitpod-dev-com bot Loading

csweichel commented Dec 13, 2021

roboquat commented Dec 13, 2021

roboquat commented Dec 13, 2021

kylos101 commented Dec 13, 2021

kylos101 commented Nov 22, 2021 •

edited

Loading

kylos101 commented Nov 22, 2021 •

edited

Loading

kylos101 commented Nov 22, 2021 •

edited by werft-gitpod-dev-com bot

Loading

kylos101 commented Nov 25, 2021 •

edited by werft-gitpod-dev-com bot

Loading

kylos101 commented Nov 25, 2021 •

edited by werft-gitpod-dev-com bot

Loading

kylos101 commented Nov 26, 2021 •

edited by werft-gitpod-dev-com bot

Loading

kylos101 commented Nov 26, 2021 •

edited by werft-gitpod-dev-com bot

Loading

codecov bot commented Nov 26, 2021 •

edited

Loading

iQQBot commented Nov 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading

kylos101 Dec 10, 2021 •

edited

Loading

geropl Dec 10, 2021 •

edited

Loading

kylos101 commented Dec 10, 2021 •

edited

Loading

csweichel commented Dec 13, 2021 •

edited

Loading

kylos101 commented Dec 13, 2021 •

edited by werft-gitpod-dev-com bot

Loading