Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer]: bump rabbitmq chart to remove deprecated kube api #7041

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Dec 2, 2021

Description

RabbitMQ used the deprecated pod disruption budget API. This has been upgraded in the latest version of the chart.

As we use helm template to generate the YAML, this fakes the Kubernetes version. There, we have to set the kubeVersion global in the RabbitMQ template

Related Issue(s)

Fixes #6829

How to test

Deploy an instance with the Installer.

Release Notes

[Installer]: Update RabbitMQ chart

Documentation

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Dec 6, 2021

/werft run

👍 started the job as gitpod-build-sje-installer-rabbitmq-pdb.1

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #7041 (ec82f88) into main (da3991c) will decrease coverage by 13.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #7041       +/-   ##
==========================================
- Coverage   19.04%   5.76%   -13.29%     
==========================================
  Files           2      13       +11     
  Lines         168    1162      +994     
==========================================
+ Hits           32      67       +35     
- Misses        134    1094      +960     
+ Partials        2       1        -1     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
installer/pkg/common/render.go 0.00% <0.00%> (ø)
installer/pkg/common/storage.go 0.00% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
installer/pkg/common/common.go 4.64% <0.00%> (ø)
installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/configmap.go 29.71% <0.00%> (ø)
installer/pkg/common/ca.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da3991c...ec82f88. Read the comment docs.

@mrsimonemms
Copy link
Contributor Author

mrsimonemms commented Dec 8, 2021

/werft run

👍 started the job as gitpod-build-sje-installer-rabbitmq-pdb.3

@mrsimonemms mrsimonemms marked this pull request as ready for review December 8, 2021 10:27
@mrsimonemms mrsimonemms requested a review from a team December 8, 2021 10:27
@roboquat
Copy link
Contributor

roboquat commented Dec 9, 2021

LGTM label has been added.

Git tree hash: 1982fa9ef5ec7ccdd912b1c6448ec262c4d486fb

@roboquat
Copy link
Contributor

roboquat commented Dec 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: princerachit

Associated issue: #6829

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 0ba2986 into main Dec 9, 2021
@roboquat roboquat deleted the sje/installer-rabbitmq-pdb branch December 9, 2021 08:59
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Installer]: update RabbitMQ Helm chart when PodDisruptionBudget update applied
3 participants