Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Change PeriodicDeleter interval: 2s->30s #7940

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Feb 1, 2022

Description

Reduce idle load on SH installations

Related Issue(s)

Fixes #

How to test

Release Notes

reduce idle DB load on SH installations

Documentation

@roboquat roboquat added release-note team: webapp Issue belongs to the WebApp team labels Feb 1, 2022
@roboquat roboquat added the size/M label Feb 1, 2022
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #7940 (e24e81d) into main (1dbe676) will decrease coverage by 23.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7940       +/-   ##
===========================================
- Coverage   33.27%   10.20%   -23.07%     
===========================================
  Files          33       18       -15     
  Lines        4673     1009     -3664     
===========================================
- Hits         1555      103     -1452     
+ Misses       3001      905     -2096     
+ Partials      117        1      -116     
Flag Coverage Δ
components-gitpod-cli-app 10.20% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
components-ws-manager-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go
...-manager/pkg/manager/internal/workpool/workpool.go
components/ws-manager/pkg/manager/status.go
components/ws-manager/pkg/manager/imagespec.go
...omponents/ws-manager/pkg/manager/pod_controller.go
components/local-app/pkg/auth/auth.go
components/ws-manager/pkg/manager/manager.go
components/ws-manager/pkg/manager/manager_ee.go
components/ws-manager/pkg/clock/clock.go
components/ws-manager/pkg/manager/probe.go
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dbe676...e24e81d. Read the comment docs.

@AlexTugarev
Copy link
Member

/lgtm

Thanks for the change!

@roboquat
Copy link
Contributor

roboquat commented Feb 3, 2022

LGTM label has been added.

Git tree hash: 1d36f453da60a2b3df426191ad69004beab05805

@AlexTugarev
Copy link
Member

/approve no-issue

pushing...

@roboquat
Copy link
Contributor

roboquat commented Feb 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev

Associated issue requirement bypassed by: AlexTugarev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 6c0c82c into main Feb 3, 2022
@roboquat roboquat deleted the gpl/periodic-deleter branch February 3, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants