Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change extensions marketplace in product.json #154

Closed
Vnzq4Qje3zzU opened this issue Oct 14, 2021 · 3 comments
Closed

Change extensions marketplace in product.json #154

Vnzq4Qje3zzU opened this issue Oct 14, 2021 · 3 comments

Comments

@Vnzq4Qje3zzU
Copy link

Vnzq4Qje3zzU commented Oct 14, 2021

I don't know if it works with VS Code directly but in VSCodium and code-server you can change the marketplace that provides extensions by replacing the api endpoints in the file product.json :

https://github.com/VSCodium/vscodium/blob/master/DOCS.md#how-to-use-the-vs-code-marketplace
https://github.com/cdr/code-server/blob/main/docs/FAQ.md#how-do-i-use-my-own-extensions-marketplace

I tried the same thing with OpenVSCode Server but it was still using the Open VSX marketplace. I successfully changed it after manually replacing all urls appearances of it in multiple files but it would be cool if it worked directly.

update: is extensionAllowedProposedApi working properly too ?

@akosyakov
Copy link
Member

It sounds like a hack though. product.json is designed to be built time artefact. The thing is that web workbench and server are 2 different applications, so after building you can publish first to CDN service and it has to be self contained, i.e. product.json should be inlined. I can see how it can be solved if web workbench is only served by the served, but not generally. We could add an env var which replaces values in some files after the build only for standalone variant. Why do you want to change the marketplace?

update: is extensionAllowedProposedApi working properly too ?

Not sure what you mean? Semantics should work correct, only listed extensions can use it.

@Vnzq4Qje3zzU
Copy link
Author

Vnzq4Qje3zzU commented Oct 15, 2021

Why do you want to change the marketplace?

Changing to Microsoft's marketplace gives a chance to install proprietary extensions like live-share, there are discussions about license stuff (microsoft#31168) though.

Not sure what you mean? Semantics should work correct, only listed extensions can use it.

Well, I tried two extensions from Microsoft (live-share and copilot) and added them to extensionAllowedProposedApi but they didn't detected it. I tried with code-server and there was no such warnings (I still can't make them work there but I think it's because of a non-related github auth issue). From what you just said it's probably because I didn't rebuild the whole application with the edited product.json (?).

@akosyakov
Copy link
Member

akosyakov commented Oct 20, 2021

Changing to Microsoft's marketplace gives a chance to install proprietary extensions like live-share, there are discussions about license stuff (microsoft#31168) though.

I don't think it is a valid reason. I also doubt it would be enough these services are likely to check identify of a client somehow to verify that it is real VS Code. Anyway it is not a goal of the project to try to work around MS protection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants