[full] Upgrade .NET SDK from 2.2 → 3.1 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once the CircleCI build is through, you'll be able to try the new .NET 3.0 image on Gitpod like so:
image: gitpod/workspace-dotnet:branch-jx-upgrade-dotnet
FROM gitpod/workspace-dotnet:branch-jx-upgrade-dotnet |
|
And... the base image build failed. Interestingly, when you do: It says:
Also, then it just fails with: without more information. |
|
Trying with Ping @sylvestre: Is it possible that the artifact called |
|
@jankeromnes you should have a better error message in the log ;) |
|
I agree! But unfortunately, I don't see a better error message. 😕 Here is the full log: view full logs |
|
/me sends more ☕ to @jankeromnes
|
|
Ah, indeed. 🤦♂ Thanks! Now I just need to figure out why this other package is installed, and remove it. |
|
Looks like clang-tools is coming from Ubuntu when it should come from apt.llvm.org If -t doesn't work, there is always the option to force-force-force with |
|
Hey, that's a cool trick, thanks! But now I wonder why we even have |
jankeromnes
force-pushed
the
jx/upgrade-dotnet
branch
from
daa986b
to
f27cf6a
Compare
|
Ah, maybe that's the underlying problem:
EDIT: Reported as https://bugs.llvm.org/show_bug.cgi?id=43676 just in case. |
|
@jankeromnes can this be rebased and merged? |
Ah yes, probably. |
jankeromnes
force-pushed
the
jx/upgrade-dotnet
branch
from
f27cf6a
to
1fd1afb
Compare
|
.NET 3.1 is now the recommended version:
(source) |
jankeromnes
force-pushed
the
jx/upgrade-dotnet
branch
from
1fd1afb
to
f7fd608
Compare
|
Failed with: Re-triggering the build. |
jankeromnes
changed the title
|
The I'll try to test the .NET 3.1 upgrade with https://github.com/ppy/osu and https://github.com/ppy/osu-framework, cc @sr229 EDIT: Actually these projects already require ".NET Core 3.1 SDK or higher", so we have no choice but to merge this upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET 3.0 is the currently recommended version on: https://dotnet.microsoft.com/download
Also, .NET 2.2 is in maintenance mode, and support ends on 2019-12-23: https://dotnet.microsoft.com/download/dotnet-core