Not show title "Info" if there is not any information to display #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering if we should do the same as you did in issue #210. I think its better to show the user that there is no info and show that as a message instead of nothing. They may think its a bug? |
|
@RolfKoenders No, I do not think so, just now, users can think it's a mistake. |
andrewda
approved these changes
Aug 6, 2017
housseindjirdeh
approved these changes
Aug 7, 2017
|
Thanks for this @lex111 :) You make a good point @RolfKoenders but I'm good either way to be honest. Happy to further discuss if we feel like we should be having a message here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent render EntityInfo component if there is nothing to show (eg github-beta).