Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong wording for "commented on pull request" #261

Closed
machour opened this issue Aug 16, 2017 · 2 comments
Closed

Wrong wording for "commented on pull request" #261

machour opened this issue Aug 16, 2017 · 2 comments
Labels
🐛 bug good for beginners help wanted

Comments

@machour
Copy link
Member

machour commented Aug 16, 2017

Currently, it's displayed as "User created on pull request" :

wrong wording

it should be "commented on"
@machour machour mentioned this issue Aug 16, 2017
Merged
@Antoine38660
Copy link
Member

Antoine38660 commented Aug 16, 2017 •
edited
Loading

Same bug here

simulator screen shot 16 aout 2017 a 16 59 30 simulator screen shot 16 aout 2017 a 16 59 16

As you can see, sometimes it's the good word

@lex111
Copy link
Member

lex111 commented Aug 16, 2017 •
edited
Loading

This is because GitHub returns the created status in case a comment has been added, so it should be commented.

housseindjirdeh pushed a commit that referenced this issue Aug 16, 2017
@machour
fix(events): Fix wrong wording for commented on pull request (#262)
182bc11 
Closes #261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug good for beginners help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@machour @alejandronanez @lex111 @Antoine38660