Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(repository-list-item): add forks count #373

Merged
merged 1 commit into from
Sep 28, 2017
Merged

feat(repository-list-item): add forks count #373

merged 1 commit into from
Sep 28, 2017

Conversation

lex111
Copy link
Member

@lex111 lex111 commented Sep 27, 2017

image

housseindjirdeh
housseindjirdeh requested changes Sep 28, 2017
View reviewed changes
Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful thank you. The only thing I can see from the screenshot is that it looks like there's a little spacing between the fork icon and the number. If that's the case, do you think we should add a little negative right margin?

@lex111
Copy link
Member Author

lex111 commented Sep 28, 2017

@housseindjirdeh yup, you are right, fixed.
image

housseindjirdeh
housseindjirdeh approved these changes Sep 28, 2017
View reviewed changes
Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesomeee, thank you @lex111 🎉

@housseindjirdeh housseindjirdeh merged commit 2010038 into master Sep 28, 2017
@andrewda andrewda deleted the add-forks-count branch October 2, 2017 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machour machour machour approved these changes

@alejandronanez alejandronanez alejandronanez approved these changes

@andrewda andrewda andrewda approved these changes

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lex111 @machour @alejandronanez @andrewda @housseindjirdeh