feat(markdown): Use markdown rendered on GitHub side #386
Conversation
|
Noticed yet a few more problems |
|
Ok, so this is turning out to be more than small fixes for markdown. So we're getting rid of MarkdownHtmlView in favor of GithubHtmlView. Still work in progress to fix some small glitches |
machour
added
high priority
ready for review
🏗️ work in progress
and removed
🏗️ work in progress
ready for review
labels
|
bummer: syntax highlighting doesn't work anymore.. fixing it now. |
| <MarkdownHtmlView | ||
| source={comment.body} | ||
| <GithubHtmlView | ||
| source={comment.body_html} |
There was a problem hiding this comment.
I think you might have meant to use comment.body. Noticing this when I open an issue:
From the looks of it, you may have accidentally swapped it by accident :)
There was a problem hiding this comment.
@housseindjirdeh We should be using only comment.body_html from now on instead. I tried the branch again and everything works fine for me. Could you give it a new try?
Fair enough, your comment have made me realize that Adding a comment was broken, I fixed it and completely got rid of comment.body :D
There was a problem hiding this comment.
Yeah was thinking the same thing, appreciate you diving in and removing body entirely since we don't really use it anymore
machour
changed the title
Silenced all missing keys warnings.
Fixed an issue where a mention or a issue link wasn't recognized at the start of a line.
#381 <- should work
@housseindjirdeh <- should work too