-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(markdown): Use markdown rendered on GitHub side #386
feat(markdown): Use markdown rendered on GitHub side #386
Conversation
Ok, so this is turning out to be more than small fixes for markdown. So we're getting rid of MarkdownHtmlView in favor of GithubHtmlView. Still work in progress to fix some small glitches |
bummer: syntax highlighting doesn't work anymore.. fixing it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid. Noticed one thing you may have missed :)
<MarkdownHtmlView | ||
source={comment.body} | ||
<GithubHtmlView | ||
source={comment.body_html} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@housseindjirdeh We should be using only comment.body_html from now on instead. I tried the branch again and everything works fine for me. Could you give it a new try?
Fair enough, your comment have made me realize that Adding a comment was broken, I fixed it and completely got rid of comment.body :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah was thinking the same thing, appreciate you diving in and removing body
entirely since we don't really use it anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silenced all missing keys warnings.
Fixed an issue where a mention or a issue link wasn't recognized at the start of a line.
#381 <- should work
@housseindjirdeh <- should work too