Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for editing and deleting issue comments #24

Closed
housseindjirdeh opened this issue Jul 12, 2017 · 13 comments
Closed

Allow for editing and deleting issue comments #24

housseindjirdeh opened this issue Jul 12, 2017 · 13 comments
Labels
assigned enhancement has pr

Comments

@housseindjirdeh
Copy link
Member

Would definitely be awesome to have the ability to edit and delete issue comments!
@housseindjirdeh housseindjirdeh mentioned this issue Jul 12, 2017
Closed
@tautf
Copy link
Contributor

tautf commented Aug 6, 2017 •
edited
Loading

I have to options how it looks possible and smooth to me:

  • What about enabling this by holding the comment for about 3 seconds then show the opportunities.
  • What about show 3 small dots in the right top corner and then show the opportunities.

What do you think @housseindjirdeh
I would take a look on it next week but can only test it on android is this a problem, should be or?

@RolfKoenders
Copy link
Member

Does this include adding labels and or assignees / reviewers? That would be really helpful as well.

@housseindjirdeh
Copy link
Member Author

@FlorianTaut I think both options are amazing. I think having both would be awesome 😍

I think we can start with the 3 small dots approach and when tapped - it opens an action sheet with all the options (Edit/Delete comment). We'll need to make sure that people with admin access on a repo can edit and delete anybody's comment in a thread but can only edit and delete theirs on repositories they don't have that type of access with.

I'm definitely okay with just being able to edit/delete the current user's comment and then deciding if we should expand to other user comments as well. Still think it's quite weird that we have the ability to edit other user's comments.

Once that's done, we can close this ticket and then explore adding hold functionality (I think that would just be awesome). I don't know how things will work here however with the different platforms but still think it would be great to have if we could only add it to iOS for example.

What do you think @FlorianTaut ? I have an iOS device so happy to test alongside with you 🕺

@housseindjirdeh
Copy link
Member Author

@RolfKoenders GitPoint already has that functionality for issues in a repository you have access to :) Little cog icon top right of the issue screen!

@RolfKoenders
Copy link
Member

@housseindjirdeh wow, i didn't even notice 😅 oops.

@tautf
Copy link
Contributor

tautf commented Aug 7, 2017

@housseindjirdeh sounds good for me! I would take a look at it when I come back from my holidays on Wednesday if that's not to late yet

@housseindjirdeh
Copy link
Member Author

@RolfKoenders haha that's a little surprise for you :)

@FlorianTaut Enjoy your vacations and take as long as you need my friend, will never be too late

@jouderianjr
Copy link
Member

Hey, has someone working on this issue? If not, I would like to work in it :)

@housseindjirdeh
Copy link
Member Author

housseindjirdeh commented Sep 5, 2017 •
edited
Loading

Not at the moment!! Will love it if you can take it on :)

@FlorianTaut please let us know if you're still interested in taking it however!

@jouderianjr
Copy link
Member

Cool, I started yesterday, I will create a pull request in a couple days. :D

@jouderianjr
Copy link
Member

Hey @housseindjirdeh, Do you have ideas for how we should do this edit flow? Should we open a new screen? Or maybe show a prompt with a text field?

I already did the delete action in this branch, then as soon we I finish the edit option I will open a pull request 😄

@SammyIsra
Copy link
Member

What would the prompt with a text field look like?

@jouderianjr
Copy link
Member

Hey, I just realize that React Native doesn't expose Alert/Dialogs with text input :/ So I did as a normal screen:

jouderianjr added a commit to jouderianjr/git-point that referenced this issue Sep 12, 2017
@jouderianjr
feat(issue_comment): Add edit action (gitpoint#24)
ef3c2fb
@jouderianjr jouderianjr mentioned this issue Sep 13, 2017
Merged
@machour machour added the has pr label Sep 13, 2017
jouderianjr added a commit to jouderianjr/git-point that referenced this issue Sep 15, 2017
@jouderianjr
feat(issue_comment): Improve issue comment action feature (gitpoint#24)
5f328b0 
- Add translation keys for each language.
- Show issue name in edit-issue-comment.screen.
- Code style minor improvements
jouderianjr added a commit to jouderianjr/git-point that referenced this issue Sep 19, 2017
@jouderianjr
feat(issue_comment): Add edit action (gitpoint#24)
d1a9f43
jouderianjr added a commit to jouderianjr/git-point that referenced this issue Sep 19, 2017
@jouderianjr
feat(issue_comment): Improve issue comment action feature (gitpoint#24)
e066981 
- Add translation keys for each language.
- Show issue name in edit-issue-comment.screen.
- Code style minor improvements
jouderianjr added a commit to jouderianjr/git-point that referenced this issue Sep 19, 2017
@jouderianjr
feat(issue_comment): Improve usability gitpoint#24
7c92872 
- Move action button to bottom.
- Add long press to open action menu.
housseindjirdeh pushed a commit that referenced this issue Sep 28, 2017
@jouderianjr
feat(comments): allow editing and deleting issue comments (#327)
7765b10 
* feat(issue-comment): Add delete action

* feat(issue_comment): Add edit action (#24)

* feat(issue_comment): Improve issue comment action feature (#24)

- Add translation keys for each language.
- Show issue name in edit-issue-comment.screen.
- Code style minor improvements

* feat(issue_comment): Improve usability #24

- Move action button to bottom.
- Add long press to open action menu.

* feat(issue_comment): Use TouchableOpacity for longPress

* feat(issue_comment): Improve minor UX issues

* feat(issue_comment): use bindActionCreators on edit screen

* feat(issue_comment): Set fixed height to TextInput
housseindjirdeh pushed a commit that referenced this issue Sep 30, 2017
@machour
feat(markdown): Use markdown rendered on GitHub side (#386)
5fb5ef6 
* fix(md): Add key everywhere and silence warnings

* fix(md): Make sure @Someone at the start of a line gets catched

* fix(md): Numeric entities () were processed as issues

* feat(markdown): Use GitHub rendering instead of marked()

* fix(md): Make images work again, checkboxes

* feat(md): Add support for cross-repository linking

* chore(md): clean up

* fix(md): Fix emojis & code highlight

* feat(md): adaptive images thanks to react-native-fit-image

* feat(md): rollback to zoomimage, fix resizeMode and ui

* fix(md): broken jsx

* fix(md): Fix new issue posting. Get rid of comment.body

* fix(md): Use Platform.select()

* fix(md): Fix cell align
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned enhancement has pr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@machour @RolfKoenders @jouderianjr @SammyIsra @housseindjirdeh @tautf