New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notification): Avoid repo names include keyword #426

Merged

alejandronanez merged 1 commit into gitpoint:master from chinesedfan:fix_replace

Oct 4, 2017

Member

chinesedfan commented Oct 4, 2017

The original replacement is not very safe, i.e,

'https://github.com/schacon/git-pulls/pulls/64'.replace('pulls', 'issues')
-> "https://github.com/schacon/git-issues/pulls/64"

'https://github.com/schacon/git-pulls/pulls/64'.replace(/pulls\/(\d+)$/, 'issues/$1')
-> "https://github.com/schacon/git-pulls/issues/64"


          fix(notification): Avoid repo names include keyword

818d6d9

lex111 approved these changes

View reviewed changes

Member

lex111 left a comment

Good catch 👍

alejandronanez approved these changes

View reviewed changes

alejandronanez merged commit 8a724f9 into gitpoint:master

chinesedfan deleted the fix_replace branch

October 5, 2017 02:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment