Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(translations): Add Ukrainian translation #585

Merged
merged 9 commits into from
Nov 4, 2017
Merged

feat(translations): Add Ukrainian translation #585

merged 9 commits into from
Nov 4, 2017

Conversation

Kietzmann
Copy link
Contributor

machour
machour requested changes Oct 26, 2017
View reviewed changes
Copy link
Member

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kietzmann and thank you for this contribution! 🎉

As you may have seen, the build is failing because of some errors. I left you comments to help you fix them.

If you need help setting up your environment to be able to run & test the application, please join us on gitter, we'll be glad to help.

Don't forget also to add yourself as a contributor by running yarn contributors:add

src/auth/screens/language-settings.js Outdated
@@ -59,4 +59,9 @@ export default [
emojiCode: ':flag-es:',
name: 'Español',
},
{
code: 'ua',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the ISO 639-1 form here: 'uk'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

src/auth/screens/language-settings.js Outdated
@@ -59,4 +59,9 @@ export default [
emojiCode: ':flag-es:',
name: 'Español',
},
{
code: 'ua',
emojiCode: ':flag-ua:',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'ua' is correct here. Keep it :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

src/locale/languages/uk.js Outdated
@@ -0,0 +1,343 @@
export const ru = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be uk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

@Kietzmann
Copy link
Contributor Author

@machour
Updated

@machour machour changed the title Added ukrainian translation feat(translations): Add Ukrainian translation Oct 26, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 34.548% when pulling 3f7ea28 on Kietzmann:ua_translation into 6567aa3 on gitpoint:master.

@machour
Copy link
Member

machour commented Oct 26, 2017

@Kietzmann thank you for the updates.
The travis build catched some more errors:

/home/travis/build/gitpoint/git-point/src/locale/languages/uk.js
  295:26  error  Unnecessary escape character: \`  no-useless-escape
  297:18  error  Unnecessary escape character: \`  no-useless-escape

Could you fix those too?

lex111
lex111 approved these changes Oct 26, 2017
View reviewed changes
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM 👍

@Kietzmann
Copy link
Contributor Author

@machour
Fixed

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 34.548% when pulling c9fb2bb on Kietzmann:ua_translation into 6567aa3 on gitpoint:master.

@machour
Copy link
Member

machour commented Oct 26, 2017

@Kietzmann for apostrophes, you could have used double quotes for the sentence instead, but that's fine for me. 😉

Thank you again for your contribution!

chinesedfan
chinesedfan requested changes Oct 26, 2017
View reviewed changes
Copy link
Member

@chinesedfan chinesedfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kietzmann Thanks for your translation. Do you translate based on src/locale/languages/en.js? I find some missing or redundant fields. Please check.

src/locale/languages/uk.js
searchingMessage: 'Пошук по {{query}}',
searchMessage: 'Пошук {{type}}',
repository: 'репозиторіїв',
user: 'користувачів',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noUsersFound, noRepositoriesFound

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

src/locale/languages/uk.js Outdated
closedButton: 'Закрито',
searchingMessage: 'Пошук по {{query}}',
noOpenIssues: 'Не знайдено відкритих pull-запитів!',
noClosedIssues: 'Не знайдено закритих pull-запитів!',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 keys should be fixed as noOpenPulls/noClosedPulls.

src/locale/languages/uk.js
reopenIssue: 'Відкрити знову {{issueType}}',
areYouSurePrompt: 'Ви впевнені?',
applyLabelTitle: 'Додати мітку до цієї задачі',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    comment: {
      commentActions: 'Comment Actions',
      editCommentTitle: 'Edit Comment',
      editAction: 'Edit',
      deleteAction: 'Delete',
    },

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

src/locale/languages/uk.js Outdated
website: 'Сайт',
repositories: 'Репозиторіїв',
pullRequest: 'pull-запит',
issue: 'задача',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pullRequest/issue can be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@Kietzmann
Copy link
Contributor Author

@chinesedfan
Resolved

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 34.548% when pulling 58230e3 on Kietzmann:ua_translation into 6567aa3 on gitpoint:master.

@Kietzmann
Copy link
Contributor Author

@machour
I ran yarn contributors:add and received
ERROR: [Errno 2] No such file or directory: 'contributors:add'
Could you help me with it? Thanks

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 34.548% when pulling 58230e3 on Kietzmann:ua_translation into 6567aa3 on gitpoint:master.

@machour
Copy link
Member

machour commented Oct 26, 2017

@Kietzmann did you initially run yarn ?

Try like this:

yarn
yarn contributors:add

When it asks you "What are the contribution types", select "Translations".
Let me know if it worked

chinesedfan
chinesedfan reviewed Oct 26, 2017
View reviewed changes
src/locale/languages/uk.js Outdated
lockedCommentInput:
'Заблоковано, але ви все ще можете прокоментувати...',
commentInput: 'Додати коментар...',
commentButton: 'Відправити',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete commentButton. Sorry I didn't notice this one before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@Kietzmann
Copy link
Contributor Author

@machour
It was issue with cmdtest on Ubuntu 17.04. I've resolved it.

@machour
Copy link
Member

machour commented Oct 27, 2017

@Kietzmann perfect! Were you able to run the app and check your translations in it?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 34.548% when pulling 1c6412a on Kietzmann:ua_translation into 6567aa3 on gitpoint:master.

@Kietzmann
Copy link
Contributor Author

@machour
Could you please provide some command or manual how to run it?
Thanks

@machour
Copy link
Member

machour commented Oct 27, 2017

@Kietzmann There you go buddy: https://github.com/gitpoint/git-point/blob/master/CONTRIBUTING.md#setup

You can start at step 6. We're on gitter if you encounter any problem

@Kietzmann
Copy link
Contributor Author

@machour
there are some issues while running android virtual device on ubuntu 17.04
I think that I won't have the ability to check it.

@chinesedfan chinesedfan merged commit 82b3845 into gitpoint:master Nov 4, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 39.437% when pulling 921833b on Kietzmann:ua_translation into b3e182f on gitpoint:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machour machour machour approved these changes

@chinesedfan chinesedfan chinesedfan approved these changes

@lex111 lex111 lex111 approved these changes

@andrewda andrewda andrewda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Kietzmann @coveralls @machour @chinesedfan @lex111 @andrewda