-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(translations): Add Ukrainian translation #585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kietzmann and thank you for this contribution! 🎉
As you may have seen, the build is failing because of some errors. I left you comments to help you fix them.
If you need help setting up your environment to be able to run & test the application, please join us on gitter, we'll be glad to help.
Don't forget also to add yourself as a contributor by running yarn contributors:add
@@ -59,4 +59,9 @@ export default [ | |||
emojiCode: ':flag-es:', | |||
name: 'Español', | |||
}, | |||
{ | |||
code: 'ua', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the ISO 639-1 form here: 'uk'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved
@@ -59,4 +59,9 @@ export default [ | |||
emojiCode: ':flag-es:', | |||
name: 'Español', | |||
}, | |||
{ | |||
code: 'ua', | |||
emojiCode: ':flag-ua:', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'ua' is correct here. Keep it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved
src/locale/languages/uk.js
Outdated
@@ -0,0 +1,343 @@ | |||
export const ru = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be uk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved
@machour |
@Kietzmann thank you for the updates.
Could you fix those too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM 👍
@machour |
@Kietzmann for apostrophes, you could have used double quotes for the sentence instead, but that's fine for me. 😉 Thank you again for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kietzmann Thanks for your translation. Do you translate based on src/locale/languages/en.js
? I find some missing or redundant fields. Please check.
searchingMessage: 'Пошук по {{query}}', | ||
searchMessage: 'Пошук {{type}}', | ||
repository: 'репозиторіїв', | ||
user: 'користувачів', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noUsersFound, noRepositoriesFound
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
src/locale/languages/uk.js
Outdated
closedButton: 'Закрито', | ||
searchingMessage: 'Пошук по {{query}}', | ||
noOpenIssues: 'Не знайдено відкритих pull-запитів!', | ||
noClosedIssues: 'Не знайдено закритих pull-запитів!', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 keys should be fixed as noOpenPulls/noClosedPulls.
reopenIssue: 'Відкрити знову {{issueType}}', | ||
areYouSurePrompt: 'Ви впевнені?', | ||
applyLabelTitle: 'Додати мітку до цієї задачі', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment: {
commentActions: 'Comment Actions',
editCommentTitle: 'Edit Comment',
editAction: 'Edit',
deleteAction: 'Delete',
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
src/locale/languages/uk.js
Outdated
website: 'Сайт', | ||
repositories: 'Репозиторіїв', | ||
pullRequest: 'pull-запит', | ||
issue: 'задача', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pullRequest/issue can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
@chinesedfan |
@machour |
@Kietzmann did you initially run Try like this:
When it asks you "What are the contribution types", select "Translations". |
src/locale/languages/uk.js
Outdated
lockedCommentInput: | ||
'Заблоковано, але ви все ще можете прокоментувати...', | ||
commentInput: 'Додати коментар...', | ||
commentButton: 'Відправити', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete commentButton
. Sorry I didn't notice this one before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
@machour |
@Kietzmann perfect! Were you able to run the app and check your translations in it? |
@machour |
@Kietzmann There you go buddy: https://github.com/gitpoint/git-point/blob/master/CONTRIBUTING.md#setup You can start at step 6. We're on gitter if you encounter any problem |
@machour |
#439