Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add dark theme #59

Closed
SocietasEvanescentes opened this issue Jul 14, 2017 · 2 comments
Closed

[Suggestion] Add dark theme #59

SocietasEvanescentes opened this issue Jul 14, 2017 · 2 comments

Comments

@SocietasEvanescentes
Copy link

This isn't an issue, but more of a wish lish. Dark themes are nice and alot easier on the eyes. Love the app!

@housseindjirdeh
Copy link
Member

housseindjirdeh commented Jul 15, 2017

Thank you I'm glad you like the app so much 👍

This can be a cool addition but definitely not critical in my opinion. If someone would like to get their hands building this out sooner rather than later however, that would be awesome :)

Will love to come to a complete consensus before this feature is stared. Here's what I 'm thinking:

  1. Leverage an HOC to accept theme as a prop OR use a theming library like react-native-theme
  2. Switching themes can be done in the authenticated user profile screen in the same settings screen we'll eventually add as part of Update profile details #8. Clicking a switch theme ListItem there can just open an Action Sheet (or we can have a list of radio buttons of available themes that the user can select maybe?)

Will love to hear other people's thoughts on this!

@rancidfrog
Copy link

rancidfrog commented Oct 10, 2017

Dark theme and transparent theme would be great.
Twidere - https://github.com/TwidereProject/Twidere-Android
is a twitter client with transparent theme.
Frost-for-Facebook - https://github.com/AllanWang/Frost-for-Facebook
also has Glass transparent theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants