Remove unnecessary permissions for Android: Phone and Storage #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
housseindjirdeh
approved these changes
Aug 3, 2017
There was a problem hiding this comment.
Amazing thank you so much for this @ferrannp, I didn't know RN added those permissions by default :O
Can't thank you enough for this 🙌
| }, | ||
| { | ||
| "login": "ferrannp", | ||
| "name": "Ferran Negre", |
|
Already included and deployed on our latest release. Thanks again for this @ferrannp 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native still adds two unnecessary permissions to all Android apps. Phone one is specially sensitive as is labelled as "dangerous": https://developer.android.com/guide/topics/permissions/requesting.html#normal-dangerous
If you have a dangerous permission, you are obliged to write a privacy policy for your app (referring why you need and how you use such permission).
You can read more about it in this react-native issue facebook/react-native#5886.
This PR just removes those unnecessary permissions.