Some tweaks #20
Closed
Some tweaks #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@malditogeek good input. I agree that the signup feels pretty clunky still. Links to GitHub user profiles would be very helpful and I agree we need them. We can probably do this after the release though. |
|
Ah, just noticed this was a PR, not issues. 👍 |
| @@ -3,13 +3,13 @@ | |||
| <img class="leaderboard__items__item__image" alt="{{username}} title=" {{username}} src="{{image}}" /> | |||
| </div> | |||
| <div class="suggestion-content"> | |||
| <p class="suggestion-content__name">{{username}}</p> | |||
| <p class="suggestion-content__name"><a href="https://gitter.im/{{username}}">{{username}}</a></p> | |||
|
Personally I think we should link to GitHub as we don't know whether they're a Gitter user. |
|
@malditogeek Could you style those links? |
|
@malditogeek also, the templates are used by the leaderboard so you get dud links on the home page. |
|
@cutandpastey will try, haven't run the app locally yet :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things I thought would be nice:
Up to you guys @lerouxb @cutandpastey