Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS (some pages and components) #3574

Closed
wants to merge 5 commits into from

Conversation

Publicker
Copy link

This is a start of #3504

I need to know if I am doing it right and know if is another better way to do it πŸ±β€πŸ.
I will be waiting for some feedback!

@ghost
Copy link

ghost commented Oct 7, 2019

stylelint analysis of 60d1c45 failed.
Visit the analysis results page to review error log.

posted by Sider

@mittalyashu mittalyashu self-requested a review October 8, 2019 22:33
@mittalyashu
Copy link
Member

Your changes also include formating and indentation. Can you also run yarn run lint:fix to keep it consistent?

@ghost
Copy link

ghost commented Oct 8, 2019

stylelint analysis of 255609e failed.
Visit the analysis results page to review error log.

posted by Sider

@ghost
Copy link

ghost commented Oct 8, 2019

stylelint analysis of 56b991c failed.
Visit the analysis results page to review error log.

posted by Sider

@mittalyashu
Copy link
Member

Can you also remove all the transition related styles? We do have plans to animations and transition but not right now.

@ghost
Copy link

ghost commented Oct 9, 2019

stylelint analysis of e5d027a failed.
Visit the analysis results page to review error log.

posted by Sider

@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
@gitthermal gitthermal deleted a comment Oct 9, 2019
src/renderer/components/navbar.vue Outdated Show resolved Hide resolved
src/renderer/components/sidebar.vue Outdated Show resolved Hide resolved
src/renderer/pages/repository/workspace.vue Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Oct 10, 2019

stylelint analysis of 4de2fdc failed.
Visit the analysis results page to review error log.

posted by Sider

@mittalyashu mittalyashu changed the title Refactored some pages and components Refactor CSS (some pages and components) Oct 11, 2019
Comment on lines +20 to +35

@for $i from 1 through 10
.mt-#{$i}
margin-top: $i + rem

@for $i from 1 through 10
.ml-#{$i}
margin-left: $i + rem

@for $i from 1 through 10
.mb-#{$i}
margin-bottom: $i + rem

@for $i from 1 through 10
.mr-#{$i}
margin-right: $i + rem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating for loop for margins might take a lot of space in terms of file size and we can easily add those to class based css inside components files.

@Publicker Publicker closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants