-
Notifications
You must be signed in to change notification settings - Fork 308
Conversation
I shouldn't commit while I'm sick :(
Looks good. I unminified to make it more obvious what's happening. My thoughts are that javascript should be minified in a build step pre-deploy (whether minified js is version-controlled or not). No hard feelings if you want to revert :) |
I'd rather stick with our existing convention and the recommended convention from Segment.io is minified, doesn't really matter to me however. |
I'd rather keep it minified so the focus stays on our code. For those that are interested, we could always include a comment in the code that points to an un-minified version. |
Reverted :) |
I added the doc link. Feel free to remove it? |
I'm fine with that. |
Initial conversion to Segment.io
haha that last thing was in response to a comment @seanlinsley made and then deleted ;) Oh my god, I made this so confusing! Just gonna merge. |
Idly looking to see if we can "hardcode" (as envvars, of course), our tracking id's, so we're not needlessly depending on segment.io to simply look them up |
This moves us to Segment.io which makes piping our analytics data to other providers super easy. The idea would be that we setup Segment.io with Google Analytics and in the future if we choose more services or a replacement service, switching will be easy.
It needs to be easy because I'll be adding JS event tracking to most user interactions in the neat future. This gives us a single API to work with instead of 20 :)
Ready to go!