Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Initial conversion to Segment.io #2337

Merged
merged 4 commits into from
May 1, 2014
Merged

Initial conversion to Segment.io #2337

merged 4 commits into from
May 1, 2014

Conversation

clone1018
Copy link
Contributor

This moves us to Segment.io which makes piping our analytics data to other providers super easy. The idea would be that we setup Segment.io with Google Analytics and in the future if we choose more services or a replacement service, switching will be easy.

It needs to be easy because I'll be adding JS event tracking to most user interactions in the neat future. This gives us a single API to work with instead of 20 :)

Ready to go!

@patcon
Copy link
Contributor

patcon commented May 1, 2014

Looks good. I unminified to make it more obvious what's happening. My thoughts are that javascript should be minified in a build step pre-deploy (whether minified js is version-controlled or not). No hard feelings if you want to revert :)

@clone1018
Copy link
Contributor Author

I'd rather stick with our existing convention and the recommended convention from Segment.io is minified, doesn't really matter to me however.

@seanlinsley
Copy link
Contributor

I'd rather keep it minified so the focus stays on our code. For those that are interested, we could always include a comment in the code that points to an un-minified version.

@patcon
Copy link
Contributor

patcon commented May 1, 2014

Reverted :)

@patcon
Copy link
Contributor

patcon commented May 1, 2014

I added the doc link. Feel free to remove it?

@clone1018
Copy link
Contributor Author

I'm fine with that.

patcon added a commit that referenced this pull request May 1, 2014
Initial conversion to Segment.io
@patcon patcon merged commit e1faf2b into master May 1, 2014
@patcon
Copy link
Contributor

patcon commented May 1, 2014

haha that last thing was in response to a comment @seanlinsley made and then deleted ;)

Oh my god, I made this so confusing! Just gonna merge.

@seanlinsley seanlinsley deleted the switch-to-segment branch May 1, 2014 21:31
@patcon
Copy link
Contributor

patcon commented May 1, 2014

Idly looking to see if we can "hardcode" (as envvars, of course), our tracking id's, so we're not needlessly depending on segment.io to simply look them up

Like here: http://pivotallabs.com/how-to-use-analytics-js-to-fix-your-analytics-code-and-achieve-metrics-nirvana/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants