Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash and miscellaneous cleanup #223

Merged
merged 6 commits into from Apr 29, 2021
Merged

Fix crash and miscellaneous cleanup #223

merged 6 commits into from Apr 29, 2021

Commits on Apr 26, 2021

  1. Change PBGitGrapher initWithRepository: to init since it doesn't actu… 

    …ally use PBGitRepository
    @ksuther
    ksuther committed Apr 26, 2021
    Copy the full SHA
    c49c029 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary method that just calls its superclass implementation

    @ksuther
    ksuther committed Apr 26, 2021
    Copy the full SHA
    1dfeab7 View commit details
    Browse the repository at this point in the history

  3. Fix crash when closing a repository while the commits are still being… 

    … loaded
    @ksuther
    ksuther committed Apr 26, 2021
    Copy the full SHA
    74f1e4b View commit details
    Browse the repository at this point in the history

  4. Remove inPBRepo argument since we have it as an instance variable alr… 

    …eady
    @ksuther
    ksuther committed Apr 26, 2021
    Copy the full SHA
    383515a View commit details
    Browse the repository at this point in the history

  5. Don't retain the delegate for the entirety of graphCommits: since we … 

    …only need it at the end of the method
    @ksuther
    ksuther committed Apr 26, 2021
    Copy the full SHA
    1224dd0 View commit details
    Browse the repository at this point in the history

  6. Remove instance variables that have a FIXME on them 

    Reference the repository and windowController proeprties instead
    @ksuther
    ksuther committed Apr 26, 2021
    Copy the full SHA
    22829f4 View commit details
    Browse the repository at this point in the history