Skip to content

Commit

Permalink
changed 6 default keyboard shortcuts using {,},[,] as problematic on …
Browse files Browse the repository at this point in the history 
…German/Norwegian keyboards (#2423)
  • Loading branch information
@giuspen
giuspen committed Jan 26, 2024
1 parent 9afdcbf commit bdd8737
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/ct/ct_menu_actions.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,9 @@ void CtMenu::init_actions(CtActions* pActions)
_("Add a Table Column"), sigc::mem_fun(*pActions, &CtActions::table_column_add)});
_actions.push_back(CtMenuAction{editor_cat, "table_column_delete", "ct_edit_delete", _("De_lete Column"), None,
_("Delete the Selected Table Column"), sigc::mem_fun(*pActions, &CtActions::table_column_delete)});
_actions.push_back(CtMenuAction{editor_cat, "table_column_left", "ct_go-back", _("Move Column _Left"), KB_CONTROL+"braceleft",
_actions.push_back(CtMenuAction{editor_cat, "table_column_left", "ct_go-back", _("Move Column _Left"), KB_CONTROL+KB_SHIFT+"b",
_("Move the Selected Column Left"), sigc::mem_fun(*pActions, &CtActions::table_column_left)});
_actions.push_back(CtMenuAction{editor_cat, "table_column_right", "ct_go-forward", _("Move Column _Right"), KB_CONTROL+"braceright",
_actions.push_back(CtMenuAction{editor_cat, "table_column_right", "ct_go-forward", _("Move Column _Right"), KB_CONTROL+KB_SHIFT+"m",
_("Move the Selected Column Right"), sigc::mem_fun(*pActions, &CtActions::table_column_right)});
_actions.push_back(CtMenuAction{editor_cat, "table_column_increase_width", "ct_go-forward",
_("Increase Column Width"), KB_ALT+"greater",
Expand All @@ -184,9 +184,9 @@ void CtMenu::init_actions(CtActions* pActions)
_("Paste a Table Row"), sigc::mem_fun(*pActions, &CtActions::table_row_paste)});
_actions.push_back(CtMenuAction{editor_cat, "table_row_delete", "ct_edit_delete", _("De_lete Row"), KB_SHIFT+KB_ALT+"q",
_("Delete the Selected Table Row"), sigc::mem_fun(*pActions, &CtActions::table_row_delete)});
_actions.push_back(CtMenuAction{editor_cat, "table_row_up", "ct_go-up", _("Move Row _Up"), KB_CONTROL+"bracketleft",
_actions.push_back(CtMenuAction{editor_cat, "table_row_up", "ct_go-up", _("Move Row _Up"), KB_CONTROL+KB_SHIFT+"j",
_("Move the Selected Row Up"), sigc::mem_fun(*pActions, &CtActions::table_row_up)});
_actions.push_back(CtMenuAction{editor_cat, "table_row_down", "ct_go-down", _("Move Row _Down"), KB_CONTROL+"bracketright",
_actions.push_back(CtMenuAction{editor_cat, "table_row_down", "ct_go-down", _("Move Row _Down"), KB_CONTROL+"j",
_("Move the Selected Row Down"), sigc::mem_fun(*pActions, &CtActions::table_row_down)});
_actions.push_back(CtMenuAction{editor_cat, "table_rows_sort_descending", "ct_sort-desc", _("Sort Rows De_scending"), None,
_("Sort all the Rows Descending"), sigc::mem_fun(*pActions, &CtActions::table_rows_sort_descending)});
Expand Down Expand Up @@ -218,10 +218,10 @@ void CtMenu::init_actions(CtActions* pActions)
_("Decrease CodeBox Width"), KB_ALT+"parenleft",
_("Decrease the Width of the CodeBox"), sigc::mem_fun(*pActions, &CtActions::codebox_decrease_width)});
_actions.push_back(CtMenuAction{editor_cat, "codebox_increase_height", "ct_go-down",
_("Increase CodeBox Height"), KB_ALT+"bracketright",
_("Increase CodeBox Height"), KB_CONTROL+KB_SHIFT+"i",
_("Increase the Height of the CodeBox"), sigc::mem_fun(*pActions, &CtActions::codebox_increase_height)});
_actions.push_back(CtMenuAction{editor_cat, "codebox_decrease_height", "ct_go-up",
_("Decrease CodeBox Height"), KB_ALT+"bracketleft",
_("Decrease CodeBox Height"), KB_CONTROL+KB_SHIFT+"u",
_("Decrease the Height of the CodeBox"), sigc::mem_fun(*pActions, &CtActions::codebox_decrease_height)});

const char* fmt_cat = _("Format");
Expand Down

1 comment on commit bdd8737

@vitusb
Copy link

@vitusb vitusb commented on bdd8737 Apr 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Giuseppe,

i'm still unable to enter a BACKSLASH on my german keyboard, by using ALT-GR and "backslash" on a combined german key.

When using ALT-GR + "\" ... i will get ...

1 1 2-german-keyboard-alt-gr-for-backslash-error01

1 1 2-german-keyboard-alt-gr-for-backslash-error02

I think, the problematic line is Line 200 in ct_menu_actions.cc v1.1.2 blob:

_actions.push_back(CtMenuAction{editor_cat, "codebox_change_properties", "ct_codebox_edit", _("Change CodeBox _Properties..."), KB_CONTROL+"backslash",

If I'm not mistaken, the following mappings are still available:

KB_CONTROL+KB_SHIFT+"g", KB_CONTROL+KB_SHIFT+"y" and KB_CONTROL+KB_SHIFT+"z" ...

So, i think the patch could be:

_actions.push_back(CtMenuAction{editor_cat, "codebox_change_properties", "ct_codebox_edit", _("Change CodeBox _Properties..."), KB_CONTROL+KB_SHIFT+"g",
or ...
_actions.push_back(CtMenuAction{editor_cat, "codebox_change_properties", "ct_codebox_edit", _("Change CodeBox _Properties..."), KB_CONTROL+KB_SHIFT+"y",
or ...
_actions.push_back(CtMenuAction{editor_cat, "codebox_change_properties", "ct_codebox_edit", _("Change CodeBox _Properties..."), KB_CONTROL+KB_SHIFT+"z",

Best regards,
vitusb

Please sign in to comment.