Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Tree Import Option Crash - Latest Version #1593

Closed
javadevelopment4 opened this issue Apr 7, 2021 · 12 comments
Closed

Cherry Tree Import Option Crash - Latest Version #1593

javadevelopment4 opened this issue Apr 7, 2021 · 12 comments

Comments

@javadevelopment4
Copy link

Downloaded the latest version from the web-site

I have 3,000 text files in a folder. When i tried to import the folder via import option it got crashed instead of importing one by one...

I have also tried with 3,000 html files as well..It goes the same result

Looks the files needs to be processed one by one...

@giuspen
Copy link
Owner

giuspen commented Apr 7, 2021

No I rather think that one of your files causes the crash. If you try to import from a folder of two text files is it working?

@javadevelopment4
Copy link
Author

If i import files one by one, all the text files are working fine
if i import two files in a folder it is working fine
if i import the folder which contains all the files it is crashing immediately.

Note: It is not crashing in the middle. as soon as clicked import or choosing the folder with huge files.

@giuspen
Copy link
Owner

giuspen commented Apr 7, 2021

Maybe it really goes out of memory

@javadevelopment4
Copy link
Author

Few More Obervations

some time it quits quitted without any message

some times it quites with the close dialog program from windows

some time a strange error ....

Can you please import folder with huge text or html files (may be 2,000 or 3,000) files??

You can duplicate a single file to en number of files freely using (https://www.skyjuicesoftware.com/software/QuickFileDuplicator/index.html) - free for non-commercial use.

@javadevelopment4
Copy link
Author

@giuspen are you able to reproduced the error with huge files?

@giuspen
Copy link
Owner

giuspen commented May 8, 2021

Haven't tried yet, easier if you give me something to try with

@javadevelopment4
Copy link
Author

@giuspen Attach

uploaded the sample files which i have tried. unzip and import the entire folder in cherry tree and it will be crashed.

https://easyupload.io/ry11mq

@giuspen
Copy link
Owner

giuspen commented May 17, 2021

Thanks for providing the files to test with so I could reproduce easily, it was not an out of memory, it will be ok in upcoming 0.99.37

@giuspen giuspen closed this as completed May 17, 2021
@javadevelopment4
Copy link
Author

Below are the problems notices.

#1 - Looks the contents of the nodes are not indexed. Search all the nodes after importing the text files folder is very slow for a keyword
#2 - When searched for a keyword in all the nodes, the search is keeps on going and take more than several minutes

Suggestion:
Index all the contents and unique keywords
Search would be type-ahead and fast
The results should be returned in less than 5 seconds.

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Jun 1, 2021
https://build.opensuse.org/request/show/895972
by user dimstar + dimstar_suse
- Update to version 0.99.37:
  * Fix crashing Glib::convert_with_fallback(),
    (gh#giuspen/cherrytree#1593).
  * Fix after undo, redo jumps to the top of the document,
    (gh#giuspen/cherrytree#1151).
  * Assigned keyboard shortcut to move table columns Left/Right:
    Ctrl+{ and Ctrl+}.
  * Assigned keyboard shortcut to move table rows Up/Down: Ctrl+[
    and Ctrl+], (gh#giuspen/cherrytree#1626).
  * Ctrl+Arrows in tables disconnected from cells navigation,
    Ctrl+( and Ctrl+) to navigate Up/Down; Tab and Shift+Tab for
    navigate Right/Left, (gh#giuspen/cherrytree#194).
  * Help--Open Preferences Directory moved under File--Preferences.
  * Fix content in the table can be modified while the node is read
    only, (gh#giuspen/cherrytree#1674).
  * Preferences file export complete.
@javadevelopment4
Copy link
Author

The search is very slow when searched for a text in whole nodes. It takes minutes. It would be helpful if it can be optimized

@javadevelopment4
Copy link
Author

javadevelopment4 commented Jun 10, 2021 via email

@ees2
Copy link

ees2 commented Feb 21, 2022

If you try to Import From Folder of Plain Text Files, and one of the files does not have an extension, Cherry Tree crashes. To reproduce can put only one small file with no extension in a folder and it will crash trying to import the folder. Obviously not crucial as the workaround is to make sure all files have an extension like they should.

Great software, love it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants