Undo causes unexpected formatting errors

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Create a a node with any amount of text. Apply different rich-text formats 
to discrete portions of the text, such as bolding some words, highlighting 
others, adding bullet lists, underlines, etc.
2. Use ctrl+z or Undo command to revert some of these changes, and observe that 
the rich-text formatting gets distrupted (e.g., a whole section might now 
become unerlined).

What version of the product are you using? On what operating system?

Using cherytree version 0.35.6 with Ubuntu 14.10 64-bit.

Original issue reported on code.google.com by leonardo...@gmail.com on 5 Jan 2015 at 3:17

[Bystroushaak]

I can confirm this.

[Bystroushaak]

Okay. Today I encountered the bug twice and it is pretty annoying.

This is really bad bug, because it cannot be easily reproduced and presents itself only when you have large amounts of formatted text. For me, it usually presents, when I have italic and monospace fonts. Then when I press ctrl+z, the random surrounding sections gets tagged as italic/monospace.

Pressing additional ctrl+z doesn't help, you have to exit cherrytree.

Now I have one node where it can be demonstrated, so I will make a video.

[Bystroushaak]

Here is the file with exported article, so you can try it yourself:

• http://kitakitsune.org/bhole/example.ctd

And here is promised video:

• http://kitakitsune.org/bhole/example.webm

[giuspen]

Hi, I'm sorry but I'm not understanding from the video, could you describe
textually? Also I see that you have the spell check active, do you have the
same issue with and without spell check?

On 11 October 2015 at 16:52, Bystroushaak notifications@github.com wrote:

Here is the file with exported article, so you can try it yourself:

• http://kitakitsune.org/bhole/example.ctd

And here is promised video:

• http://kitakitsune.org/bhole/example.webm

—
Reply to this email directly or view it on GitHub
#23 (comment).

[Bystroushaak]

I have this file with some formating. There are HTML links, italic text, headings, maybe bold, underlined or strikethrough text. Standard stuff.

Now, I edit the file somewhere near the end and I decide to revert the change by using undo (in the video, that happens from the menu, normally I would press CTRL+u). As you can see in the video, after I do the undo, not only that the last change was reverted, but there is now large section of formatted italic text, which I didn't created. What happened was that some random italic section overflowed all the way to the next italic section.

[Bystroushaak]

Here is the text before change:

Here after the undo:

Here is highlighted the overflown italic text:

[Bystroushaak]

do you have the same issue with and without spell check?

I did tested the file and I was unable to replicate the issue with spellcheck turned off. It seem like the issue may be somehow connected with spellcheck.

[Bystroushaak]

I would like to urge this issue.

[giuspen]

Please try the following version 0.35.11+r1662:
http://www.giuspen.com/software/cherrytree-0.35.11+r1662.tar.xz
http://www.giuspen.com/software/cherrytree_0.35.11+r1662-1_all.deb

[Bystroushaak]

It seems to be working correctly now. Thanks.

[Bystroushaak]

I think the problem sometimes manifests also when I open (or maybe when I close it?) the cherrytree. Can you please check that possibility? It is kinda random, so I won't be able to provide the file.

[giuspen]

Hi, the problem seems to be a corruption of the formatting, but it is not
saved automatically so I don't think it could be at closing time.
I don't need a file but to understand when it could happen, one hypothesis
is at startup or selected node change time.
I'll analyse the code and try to get back with a version to test, in the
meanwhile please confirm that this happens only with the spell check
enabled.
On 30 Oct 2015 22:09, "Bystroushaak" notifications@github.com wrote:

I think the problem sometimes manifests also when I open (or maybe when I
close it?) the cherrytree. Can you please check that possibility? It is
kinda random, so I won't be able to provide the file.

—
Reply to this email directly or view it on GitHub
#23 (comment).

[Bystroushaak]

Yes, it never happened when the spellcheck was disabled.

[txe]

was kind of resolved, closing