Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar position/line not remembered for individual nodes #2460

Open
BileDemon opened this issue Mar 21, 2024 · 3 comments
Open

Scrollbar position/line not remembered for individual nodes #2460

BileDemon opened this issue Mar 21, 2024 · 3 comments

Comments

@BileDemon
Copy link

Version, Operative system
CherryTree 1.1.0 / Kubuntu 23.10

Describe the bug
Unfortunately with the latest version 1.1.0 CherryTree somehow doesn't remember any individual scrollbar positions or line numbers anymore, when switching between nodes. Only the very last scrollbar position is taken into account, no matter which node I select.
Can you please revert this behaviour to how it was before, where it remembered the scrollbar positions AT LEAST for the last 3 or 4 nodes.
If possible, can you please extend this to even more nodes, because sometimes it was upsetting how CherryTree regularly forgot the scrollbar position when I clicked around in the tree too much.

To Reproduce

  1. Select any random node in the tree, click on text in line number 308 or something.
  2. Select any other node, which contains at least as many lines: The scrollbar goes directly to line 308.
  3. Click on a different line number, like 555.
  4. Select yet another node in the tree. The scrollbar goes directly to line 555.
@giuspen
Copy link
Owner

giuspen commented Mar 21, 2024

Sure I'll fix this in the next few days

giuspen added a commit that referenced this issue Mar 23, 2024
@giuspen
Copy link
Owner

giuspen commented Mar 23, 2024

This should be now fixed. If you could try the test build from https://www.giuspen.net/cherrytree/#testing (called 1.1.0+5) and report if that works as expected or still has issues it would be very useful

@BileDemon
Copy link
Author

Yes, the test version works really great. Each node remembers its individual line number, the scroll bar matches the last edit positions. I can even edit as many nodes as I want, and it no longer seems to forget what I edited much earlier.

This is so much better. Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants