[backport#19601] Add single sha256 call to CHashWriter #95
+42
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyeOfPython
force-pushed
the
chashwriter_single256
branch
from
9672024
to
2b18a56
Compare
schancel
reviewed
Mar 18, 2021
| } | ||
|
|
||
| // invalidates the object | ||
| /** Compute the double-SHA256 hash of all data written to this object. |
There was a problem hiding this comment.
How is OP_CDS doing the single round of SHA256 right now?
There was a problem hiding this comment.
if (vchSig.size()) {
valtype vchHash(32);
CSHA256()
.Write(vchMessage.data(), vchMessage.size())
.Finalize(vchHash.data());
fSuccess = checker.VerifySignature(
vchSig, CPubKey(vchPubKey), uint256(vchHash));
metrics.nSigChecks += 1;
May want to refactor this as you're doing this. IDK.
EyeOfPython
force-pushed
the
chashwriter_single256
branch
from
2b18a56
to
3c63b12
Compare
schancel
reviewed
Mar 18, 2021
| @@ -112,23 +112,38 @@ class CHashWriter { | |||
| int GetVersion() const { return nVersion; } | |||
|
|
|||
| void write(const char *pch, size_t size) { | |||
| ctx.Write({(const uint8_t *)pch, size}); | |||
| ctx.Write((const uint8_t *)pch, size); | |||
There was a problem hiding this comment.
Why does this need to change? Seems like an optimization of some sort?
There was a problem hiding this comment.
No, they just have different signatures:
CHash256 &Write(Span<const uint8_t> input);
vs
CSHA256 &Write(const uint8_t *data, size_t len);
🤷♂️
schancel
reviewed
Mar 18, 2021
| uint256 GetHash() { | ||
| uint256 result; | ||
| ctx.Finalize(result); | ||
| ctx.Finalize(result.begin()); |
There was a problem hiding this comment.
Why does this need to change? Is it just to reset it?
There was a problem hiding this comment.
Again, different signatures:
void CHash256::Finalize(Span<uint8_t> output);
vs.
void CSHA256::Finalize(uint8_t hash[32]);
Should probably be refactored at some point, but not yet.
schancel
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of 3.