Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup OP_CHECKDATASIG implementation to use CHashWriter #96

Open
schancel opened this issue Mar 18, 2021 · 0 comments
Open

Cleanup OP_CHECKDATASIG implementation to use CHashWriter #96

schancel opened this issue Mar 18, 2021 · 0 comments
Labels
cleanup good first issue Good for newcomers

Comments

@schancel
Copy link
Collaborator

In #95 we introduced a backport from core to introduce a helper function for a single round of SHA256. However, the OP_CHECKDATASIG implementation uses CSHA256 still. This should likely be cleaned up to be consistent with the new helper function, and the future uses.

@EyeOfPython EyeOfPython added the good first issue Good for newcomers label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants