Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent notifications (BFF-1097) #389

Merged
merged 18 commits into from
Nov 1, 2023

Conversation

alexbejann
Copy link
Contributor

Description

Implemented silent notification for processing offline givts

@@ -0,0 +1,119 @@
{
"project_info": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the packages that we aren't using from this file?

lib/app/bootstrap.dart Outdated Show resolved Hide resolved
projectId: 'givt-dev-test',
storageBucket: 'givt-dev-test.appspot.com',
iosClientId: '117496805169-u7anlg5v1dtjpa8c7b04d0nsd75ftk83.apps.googleusercontent.com',
iosBundleId: 'net.givtapp.ios',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this go well on the dev environment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are the options generated for the production env

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the production firebaseoption file

tempUser: tempUser,
isTempUser: true,
);

final newNotificationId = await _updateNotificationId(
guid: unRegisteredUserExt.guid,
currentNotificationId: unRegisteredUserExt.notificationId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe its better to fetch the notificationId from firebase instead of the old userext

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that method, what it does? I am using the old notificationId from the user to compare the one from the the firebase. If they are different it will be changed. Meaning that the user is either logging in with a different device or reinstalled the application

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check the method as well? I am comparing the token from the userExtenstion and the one from firebase to see if he's logging in from a different device or reinstalled the app

@MaikelStuivenberg MaikelStuivenberg added the enhancement New feature or request label Oct 31, 2023
@MaikelStuivenberg MaikelStuivenberg merged commit 067c320 into develop Nov 1, 2023
1 check passed
@MaikelStuivenberg MaikelStuivenberg deleted the feat/bff-1097/silent-notifications branch November 1, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants