-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silent notifications (BFF-1097) #389
Silent notifications (BFF-1097) #389
Conversation
…t/bff-1097/silent-notifications
…t/bff-1097/silent-notifications
…t/bff-1097/silent-notifications
…t/bff-1097/silent-notifications
…t/bff-1097/silent-notifications
…t/bff-1097/silent-notifications
@@ -0,0 +1,119 @@ | |||
{ | |||
"project_info": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the packages that we aren't using from this file?
projectId: 'givt-dev-test', | ||
storageBucket: 'givt-dev-test.appspot.com', | ||
iosClientId: '117496805169-u7anlg5v1dtjpa8c7b04d0nsd75ftk83.apps.googleusercontent.com', | ||
iosBundleId: 'net.givtapp.ios', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this go well on the dev environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are the options generated for the production env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the production firebaseoption file
tempUser: tempUser, | ||
isTempUser: true, | ||
); | ||
|
||
final newNotificationId = await _updateNotificationId( | ||
guid: unRegisteredUserExt.guid, | ||
currentNotificationId: unRegisteredUserExt.notificationId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe its better to fetch the notificationId from firebase instead of the old userext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check that method, what it does? I am using the old notificationId from the user to compare the one from the the firebase. If they are different it will be changed. Meaning that the user is either logging in with a different device or reinstalled the application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check the method as well? I am comparing the token from the userExtenstion and the one from firebase to see if he's logging in from a different device or reinstalled the app
Description
Implemented silent notification for processing offline givts