The new biometricCheck AuthStatus and logic based on it is implemented (KIDS-748) #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniela510
approved these changes
Apr 5, 2024
Daniela510
reviewed
Apr 5, 2024
Comment on lines
55
to
67
|
|
||
| final biometricSetting = await BiometricsHelper.getBiometricSetting(); | ||
|
|
||
| emit( | ||
| state.copyWith( | ||
| status: AuthStatus.authenticated, | ||
| status: biometricSetting == BiometricSetting.unknown | ||
| ? AuthStatus.biometricCheck | ||
| : AuthStatus.authenticated, | ||
| user: userExt, | ||
| session: session, | ||
| navigate: navigate, | ||
| ), | ||
| ); |
There was a problem hiding this comment.
Styling opinion but i would wrap the emit in a guarded if statement like
If (biometricSetting == BiometricSetting.unknown){
emit(
state.copyWith(
status: AuthStatus.biometricCheck,
user: userExt,
session: session,
navigate: navigate,
),
);
return;
}
I think its easier to follow, but its just an opinion 🦐
There was a problem hiding this comment.
perhaps, but in this case we will have two emits, so not sure what is better)
Daniela510
reviewed
Apr 5, 2024
| void clearNavigation() => emit( | ||
| state.copyWith( | ||
| status: state.status, | ||
| navigate: AuthState._emptyNavigate, |
There was a problem hiding this comment.
Curious, why does _emptyNavigate have an underscore, when it isnt private 🤔
There was a problem hiding this comment.
it's private for AuthCubit/AuthState so cannot be accessed outside
There was a problem hiding this comment.
ohh never digested that cubit and state share private classes, cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description